Skip to content

pulseview: use mkDerivation#66869

Merged
bjornfor merged 1 commit intoNixOS:masterfrom
peterhoeg:f/pulseview
Aug 19, 2019
Merged

pulseview: use mkDerivation#66869
bjornfor merged 1 commit intoNixOS:masterfrom
peterhoeg:f/pulseview

Conversation

@peterhoeg
Copy link
Copy Markdown
Member

Motivation for this change

stdenv.mkDerivation -> the Qt specific version of mkDerivation.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @bjornfor

@ofborg ofborg bot requested a review from bjornfor August 19, 2019 06:05
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 19, 2019
@bjornfor bjornfor merged commit 374e0ad into NixOS:master Aug 19, 2019
@peterhoeg peterhoeg deleted the f/pulseview branch August 19, 2019 14:14
@peterhoeg peterhoeg restored the f/pulseview branch August 19, 2019 15:21
@peterhoeg peterhoeg deleted the f/pulseview branch August 19, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants