Conversation
|
The patches to disable tests might require more work to maintain. Do you think we could do it cleaner with just |
|
@veprbl, I uploaded a new version which uses substituteInPlace. I don't have experience maintaining packages to know which is better. Let me know what you think about the substituteInPlace version compared to the old version (strager@700f99d). |
|
@GrahamcOfBorg build folly |
|
Fails to build |
|
Yeah, f75c68c introduced problems. I'll rebase and fix them. |
Make it easier to catch possible misconfiguration and regressions for the folly package by running folly's test suite.
* operator new + align() is supported only since macOS 10.13. Disable uses of align() to support macOS 10.11 and 10.12. This affects performance but should not affect correctness. * Clang 5 fails to emit typeinfo symbols for some folly::dynamic classes. Work around this bug by compiling folly with a newer version of Clang. * Clang fails to compile some sketchy code in Boost.Atomic. Boost.Atomic is a dependency of folly. Backport the fix for this bug to Boost 1.67.
veprbl
left a comment
There was a problem hiding this comment.
Since we just had a breakage due to the patches, perhaps we could remove some of them.
| // Errors attempting to format the message should not throw | ||
| FB_LOGC(footest1234, ERR, "width overflow: %999999999999999999999d", 5); | ||
| ASSERT_EQ(1, messages.size()); | ||
| +#if 0 |
There was a problem hiding this comment.
Should we just disable PrintfTest?
| @@ -50,10 +50,10 @@ TEST(Simple, Path) { | ||
| } | ||
|
|
||
| TEST(Simple, CanonicalizeParent) { |
There was a problem hiding this comment.
Not sure if this is sandbox-safe. Should we just disable this test?
| stdenv.mkDerivation rec { | ||
| let | ||
| disableTests = import ./disable-tests.nix { inherit (stdenv) lib; }; | ||
| optionals = stdenv.lib.optionals; |
There was a problem hiding this comment.
| optionals = stdenv.lib.optionals; | |
| inherit (stdenv.lib) optionals; |
| @@ -0,0 +1,88 @@ | |||
| --- a/folly/IndexedMemPool.h | |||
There was a problem hiding this comment.
I can build folly without this patch. Is this for uses in the code built with clang 5?
| folly = callPackage ../development/libraries/folly { }; | ||
| folly = callPackage ../development/libraries/folly { | ||
| # Clang 5 miscompiles folly. Build with a newer compiler on Darwin. | ||
| stdenv = if stdenv.isDarwin then llvmPackages_7.stdenv else stdenv; |
|
macOS support was merged as a part of #62330 |
|
@strager Are you still interested in contributing the tests? |
I have no plans to work on this PR or on folly. You can take over my work if you want. |
|
Thank you for your contributions. This has been automatically marked as stale because it has had no activity for 180 days. If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity. Here are suggestions that might help resolve this more quickly:
|
|
@strager please resolve the merge conflicts. |
|
Closing. macOS support was added #62330 and @Stragger expressed he does not want to work on the tests: #59846 (comment) |
Motivation for this change
Enable building the folly library on macOS (Darwin).
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)