Skip to content

folly: 2019.04.22.00 -> 2019.05.27.00#62330

Merged
abbradar merged 1 commit intoNixOS:masterfrom
pierreis:master
Jun 1, 2019
Merged

folly: 2019.04.22.00 -> 2019.05.27.00#62330
abbradar merged 1 commit intoNixOS:masterfrom
pierreis:master

Conversation

@pierreis
Copy link
Copy Markdown
Contributor

@pierreis pierreis commented May 31, 2019 •
edited
Loading

Motivation for this change

Routine version bump + add MacOS as a supported target
Builds fine on MacOS and NixOS

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
Copy link
Copy Markdown
Member

veprbl commented May 31, 2019

@GrahamcOfBorg build folly

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label May 31, 2019
@ofborg ofborg bot requested a review from abbradar May 31, 2019 21:07
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 31, 2019
veprbl
veprbl approved these changes May 31, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes nix-review on x86_64-linux and x86_64-darwin

@abbradar
Copy link
Copy Markdown
Member

abbradar commented Jun 1, 2019

Builds, passes review.

@abbradar abbradar merged commit 366985e into NixOS:master Jun 1, 2019
@veprbl veprbl mentioned this pull request Jun 7, 2019
Closed
10 tasks
@acairncross acairncross mentioned this pull request Oct 13, 2020
Merged
10 tasks
@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@veprbl veprbl veprbl approved these changes

@abbradar abbradar Awaiting requested review from abbradar

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pierreis @veprbl @abbradar @Janik-Haag