Skip to content

trash-cli: fix build#56818

Merged
timokau merged 1 commit intoNixOS:masterfrom
timokau:trash-cli-fix
Mar 4, 2019
Merged

trash-cli: fix build#56818
timokau merged 1 commit intoNixOS:masterfrom
timokau:trash-cli-fix

Conversation

@timokau
Copy link
Copy Markdown
Member

@timokau timokau commented Mar 4, 2019

Motivation for this change

More fallout from enabling strictDeps in #55757. buildInputs are not
accessible from the check phase.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
trash-cli: fix build
aff9ebb 
More fallout from enabling strictDeps in NixOS#55757. `buildInputs` are not
accessible from the check phase.
@GrahamcOfBorg GrahamcOfBorg requested a review from rycee March 4, 2019 13:23
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 4, 2019
@timokau timokau merged commit 83dcf66 into NixOS:master Mar 4, 2019
@timokau timokau deleted the trash-cli-fix branch March 4, 2019 13:52
@xeji xeji mentioned this pull request Mar 4, 2019
Closed
10 tasks
samueldr pushed a commit that referenced this pull request Mar 10, 2019
@timokau @samueldr
trash-cli: fix build (#56818)
42db132 
More fallout from enabling strictDeps in #55757. `buildInputs` are not
accessible from the check phase.

(cherry picked from commit 83dcf66)
@samueldr
Copy link
Copy Markdown
Member

samueldr commented Mar 10, 2019

Backported for 19.03 (#56826)

[release-19.03 42db132] trash-cli: fix build (#56818)
Date: Mon Mar 4 14:52:33 2019 +0100
1 file changed, 4 insertions(+), 2 deletions(-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rycee rycee Awaiting requested review from rycee

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@timokau @samueldr @GrahamcOfBorg