Skip to content

stylelint-lsp: migrate from pnpm_9 to pnpm_11#530554

Draft
gepbird wants to merge 4 commits into
NixOS:masterfrom
gepbird:stylelint-lsp-newer-pnpm
Draft

stylelint-lsp: migrate from pnpm_9 to pnpm_11#530554
gepbird wants to merge 4 commits into
NixOS:masterfrom
gepbird:stylelint-lsp-newer-pnpm

Conversation

@gepbird

@gepbird gepbird commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Part of #529285

This package uses lockfileVersion: 6 which is rejected by pnpm_10 and pnpm_11 with this error:

stylelint-lsp-pnpm-deps> [WARN] Ignoring not compatible lockfile at /build/source/pnpm-lock.yaml
stylelint-lsp-pnpm-deps> [ERR_PNPM_NO_LOCKFILE] Cannot install with "frozen-lockfile" because pnpm-lock.yaml is absent

Including this big of a patch into nixpkgs is a bad idea: #327064.
I've submitted an upstream PR, in case it would block the removal of pnpm_9, I'll most likely fork but maybe drop it.

The enhancements and refactors are also separated into #530550 which can be merged before making the final decision on how to migrate away from pnpm_9, this PR focuses only on the pnpm_9 stuff.

Things done

@gepbird gepbird requested a review from qweered June 11, 2026 00:31
@gepbird gepbird mentioned this pull request Jun 11, 2026
Open
54 tasks
@gepbird gepbird changed the title stylelint-lsp: migrate from pnpm_8 to pnpm_11 stylelint-lsp: migrate from pnpm_9 to pnpm_11 Jun 11, 2026
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 11, 2026
qweered
qweered approved these changes Jun 11, 2026
View reviewed changes

@qweered qweered left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm if upstream accept your pr, lets see. In the worst case we can vedor it via pull request URL to avoid having whole patch in the tarball

@gepbird

gepbird commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

In the worst case we can vedor it via pull request URL to avoid having whole patch in the tarball

If the PR is open, we shouldn't do that: #476406

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 11, 2026
@qweered

qweered commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Oh yeah, I forgot about that issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@qweered qweered qweered approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gepbird @qweered