Skip to content

[Tracking] vendor patches from opened prs #476406

@Sigmanificient

Description

@Sigmanificient

As per https://github.com/NixOS/nixpkgs/tree/master/pkgs#patches:

When adding patches in this manner you should be reasonably sure that the used URL is stable. Patches referencing open pull requests will change when the PR is updated and code forges (such as GitHub) usually garbage collect commits that are no longer reachable due to rebases/amends.

In the following cases, a .patch file should be added to Nixpkgs repository, instead of retrieved:
[...]
• has a high chance to disappear in the future due to unstable or unreliable URLs

Many patches are currently using commits from opened pr and are subject to this issue. Lets fix this

nix run nixpkgs#ripgrep -- -U -n \
  'fetchpatch2?\s*\{[^}]*?\burl\s*=\s*"([^"]+)";' -r '$1' \
  pkgs | grep "github.com"

Note

When opening a pr, make sure to reference this tracking issue, so it appears below! This will help me to track it in the list

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.skill: good-first-bugThis seems like it's fixable by a non-expert3.skill: sprintableA larger issue which is split into distinct actionable tasks5.scope: trackingLong-lived issue tracking long-term fixes or multiple sub-problems6.topic: hygieneCleaning up and removing cruft
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions