github-runner: Disable node20 runtime by default#524856
Merged
Merged
Conversation
dotlambda
reviewed
May 27, 2026
Comment on lines
+20
to
+21
| # Node.js 20.x has reached EOL and is marked as insecure in Nixpkgs | ||
| # "node20" |
Member
There was a problem hiding this comment.
Suggested change
| # Node.js 20.x has reached EOL and is marked as insecure in Nixpkgs | |
| # "node20" |
Contributor
Author
There was a problem hiding this comment.
@dotlambda I feel like it would be good to keep an explanation of why we don't have node20 here while it's still there in other places.
Member
There was a problem hiding this comment.
Then at least do
Suggested change
| # Node.js 20.x has reached EOL and is marked as insecure in Nixpkgs | |
| # "node20" | |
| # Node.js 20.x has reached EOL and is marked as insecure in Nixpkgs |
Contributor
Author
There was a problem hiding this comment.
Sure, done. Also updated this comment.
qweered
approved these changes
May 27, 2026
Node.js 20 is now EOL, see NixOS#515284 Remove it from the default list of runtimes, but keep the support around as long as upstream supports it.
11a2136 to
505e832
Compare
Contributor
|
Successfully created backport PR for |
YorikSar
added a commit
to YorikSar/nix-darwin
that referenced
this pull request
Jun 1, 2026
It's marked as insecure starting with 26.05, and now github-runner package defaults to supporting only node24 See NixOS/nixpkgs#524856
YorikSar
added a commit
to YorikSar/nix-darwin
that referenced
this pull request
Jun 9, 2026
It's marked as insecure starting with 26.05, and now github-runner package defaults to supporting only node24 See NixOS/nixpkgs#524856
YorikSar
added a commit
to YorikSar/nix-darwin
that referenced
this pull request
Jun 9, 2026
It's marked as insecure starting with 26.05, and now github-runner package defaults to supporting only node24 See NixOS/nixpkgs#524856
YorikSar
added a commit
to YorikSar/nix-darwin
that referenced
this pull request
Jun 11, 2026
It's marked as insecure starting with 26.05, and now github-runner package defaults to supporting only node24 See NixOS/nixpkgs#524856
This was referenced Jun 11, 2026
Samasaur1
pushed a commit
to nix-darwin/nix-darwin
that referenced
this pull request
Jun 11, 2026
It's marked as insecure starting with 26.05, and now github-runner package defaults to supporting only node24 See NixOS/nixpkgs#524856
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.js 20 is now EOL, see #515284 Remove it from the default list of runtimes, but keep the support around as long as upstream supports it.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.