rmfakecloud: 0.0.29 -> 0.0.31 by coolGi69 · Pull Request #524309 · NixOS/nixpkgs

coolGi69 · 2026-05-26T04:48:12Z

Updates rmfakecloud, ~~and removes the env. from the pnpm stuff as otherwise @r-ryantm has issues updating it (see its logs)~~

Things done

coolGi69 · 2026-05-26T04:53:00Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 524309
Commit: 4830c14bc12139594301f7c5fe61289df4277f5a

`x86_64-linux`

✅ 1 package built:

rmfakecloud

martinetd · 2026-05-26T05:11:26Z

+  vendorHash = "sha256-A+y63w+sEleXFh4ZHgFo1IhsQ2KhqqKW4vRPi393atI=";

  # if using webUI build it
  # use env because of https://github.com/NixOS/nixpkgs/issues/358844


please remove this comment if env is no longer needed; and I'd also like either a pointer at the fix (that issue ended closed with a draft PR not merged...) or some reassurance that it works, the automated tests don't check the webui iirc -- did it work?

It seems to work on my machine (ran the binary, and navigated to the website at port 3000 on my browser).

hm actually wanted to take a spin locally and didn't work for me, it might have worked for you if you built once with env... and the cached artifact was in your nix store for second build?

(that's with your commit cherry-picked on top of nixos-unstable)

$ nix -L build -f . rmfakecloud source> structuredAttrs is enabled source> source> trying https://github.com/ddvk/rmfakecloud/archive/v0.0.31.tar.gz source> % Total % Received % Xferd Average Speed Time Time Time Current source> Dload Upload Total Spent Left Speed source> 0 0 0 0 0 0 0 0 00:01 0 source> 100 571.2k 0 571.2k 0 0 215.5k 0 00:02 0 source> unpacking source archive /build/download.tar.gz rmfakecloud-pnpm-deps> Running phase: unpackPhase rmfakecloud-pnpm-deps> unpacking source archive /nix/store/4skmvbkpw297m5ydzn1jd6j1jgx260vj-source rmfakecloud-pnpm-deps> source root is source/ui [...]] rmfakecloud-pnpm-deps> Downloading @swc/core-win32-ia32-msvc@1.9.2: 2.18 MB/9.14 MB rmfakecloud> source root is source rmfakecloud> Running phase: patchPhase rmfakecloud> Running phase: updateAutotoolsGnuConfigScriptsPhase rmfakecloud-pnpm-deps> Progress: resolved 389, reused 0, downloaded 174, added 174 rmfakecloud> Running phase: configurePhase rmfakecloud-pnpm-deps> Downloading pdfjs-dist@4.4.168: 9.57 MB/10.12 MB rmfakecloud> Executing pnpmConfigHook rmfakecloud> Error: 'pnpmDeps' must be set when using pnpmConfigHook. error: builder for '/nix/store/7m77vd07b6vh9h23m5zyp36wi4lgnsl4-rmfakecloud-0.0.31-go-modules.drv' failed with exit code 1 error (ignored): error: cannot unlink "/tmp/nix-shell.hirUFv/nix-build-rmfakecloud-pnpm-deps.drv-0/build": Directory not empty error: 1 dependencies of derivation '/nix/store/s8937l0yp7zj2hipdmlh2vc980b9ylan-rmfakecloud-0.0.31.drv' failed to build

Huh, weird... it may have been a cached artifact, I'll try collecting garbage and trying again.

Yup, it must have been cached. Tried it again after clearing my cache and it breaks.
I do want to see if there is any way around this as adding the env messes with the auto updater (or possibly modify/fix the auto update script to work with env?)

Nevermind, I see that you've already looked into nix-update, and the pr mentioned in your issue has gone stale.
I'll just revert this change as I doubt there is any fixes I could do atm. Ty for looking into this a long time ago!, sad that there aren't any new updates to this issue 🥲.

Aaah, it's all coming back to me, I was confused because r-ryantm managed to build some updates (0.0.27 -> 0.0.29), but that's because it didn't contain any UI update...

So, yeah, I don't think we can do much about this in the short term, let's stick with what we have :/

And I'll re-open the issue, even if I'm not holding my breath :)

Thanks for looking into this and making the nix-update PR!

martinetd · 2026-05-26T05:15:41Z

+  vendorHash = "sha256-A+y63w+sEleXFh4ZHgFo1IhsQ2KhqqKW4vRPi393atI=";

  # if using webUI build it
  # use env because of https://github.com/NixOS/nixpkgs/issues/358844


martinetd · 2026-05-26T06:03:34Z

+  vendorHash = "sha256-A+y63w+sEleXFh4ZHgFo1IhsQ2KhqqKW4vRPi393atI=";

  # if using webUI build it
  # use env because of https://github.com/NixOS/nixpkgs/issues/358844


Aaah, it's all coming back to me, I was confused because r-ryantm managed to build some updates (0.0.27 -> 0.0.29), but that's because it didn't contain any UI update...

So, yeah, I don't think we can do much about this in the short term, let's stick with what we have :/

And I'll re-open the issue, even if I'm not holding my breath :)

martinetd · 2026-06-09T04:03:30Z

Since no committer has had time to look at this yet, could you grab this commit in your branch if you have time?

https://github.com/martinetd/nixpkgs/commits/rmfakecloud_pnpm rmfakecloud: use pnpm 11 ?

I've checked the UI works as expected manually with new pnpm version

coolGi69 · 2026-06-09T04:08:18Z

Sure, would you like me to keep it as a seperate commit, or merge it into my commit (and if so, would I add a "Co-authored by")?

martinetd · 2026-06-09T04:10:01Z

It's functionally independent so I think a separate commit makes sense here

martinetd

Thanks! I'll link this to PRs ready to be merged once ofborg passes

coolGi69 · 2026-06-09T04:17:01Z

Unsure why Github formats stuff so weirdly... but I've cherry-picked your commit on top of my branch :)

nixos-discourse · 2026-06-09T06:28:21Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/3075

pnpm9 is now EOL and should no longer be used (NixOS#529285) Also update fetchPnpmDeps to fetcherVersion=4 as recommended

SuperSandroBot · 2026-06-10T00:43:54Z

`nixpkgs-review` result

Generated using nixpkgs-review-gha (fddef5a)

Command: nixpkgs-review pr 524309
Commit: a34aacd9f56aeef533458242c3b949627f15f2ad (subsequent changes)
Merge: 77c99ef529dfc915caf7a9581df2eca173f8d656

Logs: https://github.com/SuperSandro2000/nixpkgs-review-gha/actions/runs/27245208504

`x86_64-linux`

✅ 1 package built:

rmfakecloud

`aarch64-linux`

✅ 1 package built:

rmfakecloud

`aarch64-darwin` (sandbox = relaxed)

❌ 1 package failed to build:

rmfakecloud

martinetd · 2026-06-10T01:33:20Z

Thanks!

nixpkgs-ci · 2026-06-10T12:17:23Z

Successfully created backport PR for release-26.05:

[Backport release-26.05] rmfakecloud: 0.0.29 -> 0.0.31 #530332

…r hashes Some packages like rmfakecloud cannot be reliably updated, this makes the autoupdate script work and create content similar to this PR done manually[1] This has been discussed in Mic92#302 before but the goModules rework that was drafted at that point went stale, and we might as well work around the problem[2] in nix-update: basically, the goModules hash is based on the whole derivation, and not just the actual go dependencies being pulled, so we want to keep it late in execution order. Link: NixOS/nixpkgs#524309 [1] Link: NixOS/nixpkgs#358844 [2] Fixes Mic92#302

nixpkgs-ci Bot requested review from martinetd and pacien May 26, 2026 04:53

martinetd reviewed May 26, 2026

View reviewed changes

coolGi69 force-pushed the pkgs/rmfakecloud/update branch from 4830c14 to 99e9bba Compare May 26, 2026 05:15

martinetd approved these changes May 26, 2026

View reviewed changes

nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels May 26, 2026

coolGi69 force-pushed the pkgs/rmfakecloud/update branch from 99e9bba to 0c1b2c0 Compare May 26, 2026 05:42

martinetd approved these changes May 26, 2026

View reviewed changes

This was referenced May 26, 2026

Build go module with pnpm deps #358844

Open

update_dependency_hashes: workaround goModules hash depending on other hashes Mic92/nix-update#607

Merged

martinetd approved these changes Jun 9, 2026

View reviewed changes

SuperSandro2000 reviewed Jun 10, 2026

View reviewed changes

Comment thread pkgs/by-name/rm/rmfakecloud/package.nix Outdated

SuperSandro2000 added this pull request to the merge queue Jun 10, 2026

SuperSandro2000 removed this pull request from the merge queue due to a manual request Jun 10, 2026

coolGi69 and others added 2 commits June 10, 2026 12:42

rmfakecloud: 0.0.29 -> 0.0.31

1c7f0fa

rmfakecloud: use pnpm 11

851cbf9

pnpm9 is now EOL and should no longer be used (NixOS#529285) Also update fetchPnpmDeps to fetcherVersion=4 as recommended

coolGi69 force-pushed the pkgs/rmfakecloud/update branch from a34aacd to 851cbf9 Compare June 10, 2026 00:43

SuperSandro2000 enabled auto-merge June 10, 2026 00:47

SuperSandro2000 added this pull request to the merge queue Jun 10, 2026

Merged via the queue into NixOS:master with commit e81b81f Jun 10, 2026
26 checks passed

martinetd added the backport release-26.05 Backport PR automatically label Jun 10, 2026

nixpkgs-ci Bot mentioned this pull request Jun 10, 2026

[Backport release-26.05] rmfakecloud: 0.0.29 -> 0.0.31 #530332

Open

github-actions Bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jun 10, 2026

gepbird mentioned this pull request Jun 12, 2026

Tracking: pnpm 9 EOL #529285

Open

54 tasks

Uh oh!

Conversation

coolGi69 commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Things done

Uh oh!

coolGi69 commented May 26, 2026

nixpkgs-review result

x86_64-linux

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

martinetd commented Jun 9, 2026

Uh oh!

coolGi69 commented Jun 9, 2026

Uh oh!

martinetd commented Jun 9, 2026

Uh oh!

martinetd left a comment

Choose a reason for hiding this comment

Uh oh!

coolGi69 commented Jun 9, 2026

Uh oh!

nixos-discourse commented Jun 9, 2026

Uh oh!

Uh oh!

Uh oh!

SuperSandroBot commented Jun 10, 2026

nixpkgs-review result

x86_64-linux

aarch64-linux

aarch64-darwin (sandbox = relaxed)

Uh oh!

Uh oh!

martinetd commented Jun 10, 2026

Uh oh!

nixpkgs-ci Bot commented Jun 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

coolGi69 commented May 26, 2026 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`aarch64-darwin` (sandbox = relaxed)