fetchPnpmDeps: deprecate fetcherVersion = 2, schedule removal for 26.11#518360
Merged
Conversation
15 tasks
1f7e217 to
b23def2
Compare
Extend the existing v1 deprecation warning to also fire for `fetcherVersion = 2`, since callers should migrate directly to `fetcherVersion = 3`. Both pre-v3 versions now share a single `lib.warnIf` keyed on `fetcherVersion < 3` and produce a message parameterised by the offending version. Consolidate the manual's version-history entries: the per-item **Deprecated** and **Recommended** labels are replaced by a single sentence above the list noting that v3 is recommended and v1/v2 are scheduled for removal. Add a release note mirroring the existing v1 entry.
b23def2 to
f472a63
Compare
Contributor
Author
|
Can we merge this before branch off? No consumers left inside nixpkgs |
Contributor
Author
ethancedwards8
approved these changes
May 13, 2026
SuperSandro2000
approved these changes
May 13, 2026
gepbird
approved these changes
May 13, 2026
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #514075 and #515082
Tracking #494184
Things done