Skip to content

gui-for-singbox: 1.21.0 -> 1.23.2#515082

Merged
yayayayaka merged 2 commits into
NixOS:masterfrom
vollate:master
May 11, 2026
Merged

gui-for-singbox: 1.21.0 -> 1.23.2#515082
yayayayaka merged 2 commits into
NixOS:masterfrom
vollate:master

Conversation

@vollate

@vollate vollate commented Apr 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Upstream changelog: https://github.com/GUI-for-Cores/GUI.for.SingBox/releases/tag/v1.23.2

Also carries two patches on top of the upstream source:

  • xdg-path-and-restart-patch.patch — routes user config / kernel
    working dir under $XDG_CONFIG_HOME/GUI.for.SingBox/ on Linux
    instead of $out (which is read-only), and makes RestartApp use
    os.Executable() so the wrapped nix-store path is respected.
  • frontend-runtime-path.patch — threads the XDG config path through
    to the frontend so the sing-box working directory and PID file
    resolve to a writable location at runtime.
  • Add wrapGAppsHook3 and glib-networking to make sure the gtkwebkit handle network request correctly and fix the abnormal webview display due to missing gtk schema settings

I have tested it on my NixOS 26.05 (Yarara) x86_64 and it works perfectly.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle! 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Apr 30, 2026
@vollate vollate force-pushed the master branch 3 times, most recently from 42dc266 to c8a7b3f Compare May 8, 2026 20:52
@nixpkgs-ci nixpkgs-ci Bot removed the 8.has: package (update) This PR updates a package to a newer version label May 9, 2026
@qweered

qweered commented May 9, 2026

Copy link
Copy Markdown
Contributor

Welcome to nixpkgs! Please also add mine changes from #514083, specifically fetcherVersion 2 -> 3 migration

@qweered qweered mentioned this pull request May 9, 2026
Merged
5 tasks
@vollate

vollate commented May 9, 2026

Copy link
Copy Markdown
Contributor Author

Welcome to nixpkgs! Please also add mine changes from #514083, specifically fetcherVersion 2 -> 3 migration

Added it!

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 9, 2026
@qweered

qweered commented May 9, 2026

Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 515082
Commit: bd395740757a26a280b31c1116486adf5c9ed09e

x86_64-linux

✅ 1 package built:
  • tests.config-nix-unit

qweered
qweered approved these changes May 9, 2026
View reviewed changes

@qweered qweered left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

This was referenced May 9, 2026
Closed
Merged
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels May 9, 2026
gepbird
gepbird approved these changes May 10, 2026
View reviewed changes

@gepbird gepbird left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, tested the binary, looks good.
Just running the application without the added patch and dependencies seem to work when clicking around (no issues in the GUI, no extra logs), I haven't got to a webview or ran into issues with the path, so I can't confirm if those patches are good, but I believe you that they are needed.

ZHF: #516381

@gepbird gepbird added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label May 10, 2026
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels May 10, 2026
yayayayaka
yayayayaka approved these changes May 11, 2026
View reviewed changes

@yayayayaka yayayayaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking over maintainership!

@yayayayaka yayayayaka added this pull request to the merge queue May 11, 2026
Merged via the queue into NixOS:master with commit 169bb6b May 11, 2026
39 of 41 checks passed
@gepbird gepbird mentioned this pull request May 13, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gepbird gepbird gepbird approved these changes

@yayayayaka yayayayaka yayayayaka approved these changes

+1 more reviewer

@qweered qweered qweered approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vollate @qweered @gepbird @yayayayaka