Skip to content

mainsail: update nodejs to version 22#518024

Merged
pyrox0 merged 1 commit into
NixOS:masterfrom
epireyn:update/mainsail-nodejs
May 17, 2026
Merged

mainsail: update nodejs to version 22#518024
pyrox0 merged 1 commit into
NixOS:masterfrom
epireyn:update/mainsail-nodejs

Conversation

@epireyn

@epireyn epireyn commented May 8, 2026

Copy link
Copy Markdown
Contributor

See #515284.

I pinned the version because it does not build with nodejs 24, and is known to have had issues in the past (#477516).

Would be awesome if maintainers could open an issue upstream for them to update their requirements :).

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Resolves NixOS#515284.

I pinned the version because it does not build with nodejs 24, and is known to have had issues in the past (NixOS#477516).

Would be awesome if maintainers could open an issue upstream for them to update their requirements :).
@nixpkgs-ci nixpkgs-ci Bot requested review from Wulfsta and lovesegfault May 8, 2026 11:02
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 8, 2026
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels May 8, 2026
@qweered qweered mentioned this pull request May 8, 2026
25 tasks
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels May 9, 2026
@pyrox0 pyrox0 added this pull request to the merge queue May 17, 2026
@pyrox0 pyrox0 added the backport release-25.11 Backport PR automatically label May 17, 2026
Merged via the queue into NixOS:master with commit a847dd4 May 17, 2026
40 of 42 checks passed
@nixpkgs-ci

nixpkgs-ci Bot commented May 17, 2026

Copy link
Copy Markdown
Contributor

Backport failed for release-25.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-25.11
git worktree add -d .worktree/backport-518024-to-release-25.11 origin/release-25.11
cd .worktree/backport-518024-to-release-25.11
git switch --create backport-518024-to-release-25.11
git cherry-pick -x 308a5b74c99a2a813c9979bf338a838991228aa3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: failed backport 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. backport release-25.11 Backport PR automatically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants