mainsail: fix build by pinning to nodejs_20#477516
Merged
Merged
Conversation
Member
|
It looks like mainsail targets node 20 in their Dockerfile; if we are going to pin a version it should probably be the same as upstream, no? |
Contributor
Author
Ah, yes. I just pinned to a version that build successfully, but pinning to the version that is recommended upstream makes sense. I have adjusted the PR accordingly. |
bendlas
approved these changes
Jan 7, 2026
bendlas
left a comment
Contributor
There was a problem hiding this comment.
Tested on my raspi3 voron0
Wulfsta
approved these changes
Jan 7, 2026
13 tasks
hydra-channel-updater Bot
pushed a commit
to nixos-cuda/nixpkgs
that referenced
this pull request
May 17, 2026
Resolves NixOS#515284. I pinned the version because it does not build with nodejs 24, and is known to have had issues in the past (NixOS#477516). Would be awesome if maintainers could open an issue upstream for them to update their requirements :).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #477515
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.