Skip to content

ghostscript: fix i686 build, drop upstreamed 32-bit patch#517138

Merged
SuperSandro2000 merged 1 commit into
NixOS:stagingfrom
trofi:gc-i686-fix
May 18, 2026
Merged

ghostscript: fix i686 build, drop upstreamed 32-bit patch#517138
SuperSandro2000 merged 1 commit into
NixOS:stagingfrom
trofi:gc-i686-fix

Conversation

@trofi

@trofi trofi commented May 6, 2026

Copy link
Copy Markdown
Contributor

Without the change the build fails on staging as:

$ nix build --no-link -f. pkgsi686Linux.ghostscript --keep-going -L
...
ghostscript-with-X> applying patch /nix/store/q1dgaydqa5rvgccxz8hcwfwanqh3s71p-3c0be6e4fcffa63e4a5a1b0aec057cebc4d2562f.patch?full_index=1
ghostscript-with-X> patching file base/gdevdbit.c
ghostscript-with-X> Reversed (or previously applied) patch detected!  Assume -R? [n]
ghostscript-with-X> Apply anyway? [n]
ghostscript-with-X> Skipping patch.
ghostscript-with-X> 1 out of 1 hunk ignored -- saving rejects to file base/gdevdbit.c.rej
ghostscript-with-X> patching file base/gdevmpla.c
ghostscript-with-X> Reversed (or previously applied) patch detected!  Assume -R? [n]
ghostscript-with-X> Apply anyway? [n]
ghostscript-with-X> Skipping patch.
ghostscript-with-X> 2 out of 2 hunks ignored -- saving rejects to file base/gdevmpla.c.rej

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Without the change the build fails on `staging` as:

```
$ nix build --no-link -f. pkgsi686Linux.ghostscript --keep-going -L
...
ghostscript-with-X> applying patch /nix/store/q1dgaydqa5rvgccxz8hcwfwanqh3s71p-3c0be6e4fcffa63e4a5a1b0aec057cebc4d2562f.patch?full_index=1
ghostscript-with-X> patching file base/gdevdbit.c
ghostscript-with-X> Reversed (or previously applied) patch detected!  Assume -R? [n]
ghostscript-with-X> Apply anyway? [n]
ghostscript-with-X> Skipping patch.
ghostscript-with-X> 1 out of 1 hunk ignored -- saving rejects to file base/gdevdbit.c.rej
ghostscript-with-X> patching file base/gdevmpla.c
ghostscript-with-X> Reversed (or previously applied) patch detected!  Assume -R? [n]
ghostscript-with-X> Apply anyway? [n]
ghostscript-with-X> Skipping patch.
ghostscript-with-X> 2 out of 2 hunks ignored -- saving rejects to file base/gdevmpla.c.rej
```
@trofi trofi mentioned this pull request May 6, 2026
13 tasks
@nixpkgs-ci nixpkgs-ci Bot requested a review from tobim May 6, 2026 05:23
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels May 6, 2026
@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label May 18, 2026
@SuperSandro2000 SuperSandro2000 added this pull request to the merge queue May 18, 2026
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels May 18, 2026
Merged via the queue into NixOS:staging with commit 736f893 May 18, 2026
38 of 40 checks passed
@trofi trofi deleted the gc-i686-fix branch May 18, 2026 14:53
vcunat added a commit that referenced this pull request May 20, 2026
This PR was originally merged in commit 736f893,
but let's take it earlier into unstable/master via staging-next.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants