multivnc: fix build failure; fix semver#506445
Merged
Sigmanificient merged 2 commits intoNixOS:masterfrom Apr 6, 2026
Merged
Conversation
Member
Author
|
the package was incorrectly set at 2.8.1 while it was actually android-2.1.8 the correct version at this commit is 0.6.0: https://github.com/bk138/multivnc/blob/89225243412f43ba2903ffeda98af7fe1f8f4975/CMakeLists.txt#L3-L4
e5da428 to
81c9bb9
Compare
rhelmot
approved these changes
Apr 4, 2026
17 tasks
Sigmanificient
approved these changes
Apr 6, 2026
Member
Sigmanificient
left a comment
There was a problem hiding this comment.
Please rename in the first commit multinvc -> multivnc
the patch version of libvncserver was removing a patch required to build the deps as it is using a deprecated cmake version, causing the build to fail
81c9bb9 to
037e09f
Compare
ilai-deutel
pushed a commit
to ilai-deutel/nixpkgs
that referenced
this pull request
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.