lmms: 1.2.2 -> 1.2.2-unstable-2026-04-01#501041
Open
jaredmontoya wants to merge 1 commit intoNixOS:masterfrom
Open
lmms: 1.2.2 -> 1.2.2-unstable-2026-04-01#501041jaredmontoya wants to merge 1 commit intoNixOS:masterfrom
jaredmontoya wants to merge 1 commit intoNixOS:masterfrom
Conversation
f3cf0ca to
57b2113
Compare
viraptor
reviewed
Mar 28, 2026
| winePackages | ||
| ]; | ||
|
|
||
| patches = [ |
Contributor
There was a problem hiding this comment.
Are those patches available upstream? Can we fetchpatch instead of copying? Or are they very nix specific?
Contributor
Author
There was a problem hiding this comment.
The wine patch is nix package specific.
The gigplayer patch is fixing an issue with the build process that only manifests in nix but can probably be upstreamed, but I don't have much experience with cmake so I don't know if this patch will be accepted into LMMS. This issue can also be solved in a crude way by manually patching the path to libgig in the built binary but I opted for a patch.
dotlambda
reviewed
Mar 30, 2026
Member
dotlambda
left a comment
There was a problem hiding this comment.
Add
passthru.updateScript = unstableGitUpdater { };163d182 to
bfc2e90
Compare
bfc2e90 to
7f3120e
Compare
LMMS 1.2.2 is 6 years old and the software has undergone many changes since then, unfortunately however, no branches or tags are being made as the software progresses so we stay as close to git as possible. Co-authored-by: Alexandre Cavalheiro S. Tiago da Silva <contact@thewizard.link>
7f3120e to
12c378c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LMMS 1.2.2 is 6 years old and the software has undergone many changes since then, unfortunately however, no branches or tags are being made as the software progresses so we stay as close to git as possible.
This is a newer version of #377643
Closes #297527
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.