lmms: 1.2.2 -> 0-unstable-2025-01-28 by wizardlink · Pull Request #377643 · NixOS/nixpkgs

wizardlink · 2025-01-28T23:58:15Z

LMMS 1.2.2 is almost 5 years old and the software has undergone many changes since then, unfortunately however, no branches or tags are being made as the software progresses so we stay as close to git as possible.

I am quite unsure about the wine dependency I have, it feels wrong to depend on it but I've only found wineWowPackages.minimal having the libraries and properly building 32-bit and 64-bit applications.

closes #297527

Added dependencies:

glibc_multi
SDL -> SDL2
perl540
perl540Packages.ListMoreUtils
perl540Packages.XMLParser
substitute
wineWowPackages.minimal
libogg

Things done

Add a 👍 reaction to pull requests you find important.

wizardlink · 2025-01-30T04:30:36Z

I'm honestly not too sure about the withOptionals argument I require here, because lmms without the optional dependencies doesn't even has ALSA support, but at the same time, packing a wine derivation seems quite expensive for a package. So defining the limits of "optional" for a NixOS package seems tough here for me.

LMMS 1.2.2 is almost 5 years old and the software has undergone many changes since then, unfortunately however, no branches or tags are being made as the software progresses so we stay as close to git as possible.

wizardlink · 2025-02-05T16:30:19Z

Fixed the merge conflict it had with master.

acid-bong

Since tags weren't reset/removed, nor source did change, i'd suggest not replacing the version itself with 0, you can use 1.2.2-unstable-DATE.

And probably additionally specify that you moved it to /by-name

wizardlink · 2025-03-06T19:06:22Z

That's true, I had forgotten about that versioning rule. I will abstain from making the change for now though, I don't want to trigger the CI just because of a version change; once reviews come in and my questions are quelled I'll make sure to include that, thanks!

auroraanna · 2025-09-30T14:24:03Z

so the new packages will be lmms and libsForQt5.lmms...

edit: didn't see that the old lmms gets removed

auroraanna

is wine required for some plugins?

auroraanna · 2025-10-01T11:55:59Z

pkgs/by-name/lm/lmms/package.nix

+  meta = with lib; {
+    description = "DAW similar to FL Studio (music production software)";
+    mainProgram = "lmms";
+    homepage = "https://lmms.io";
+    license = licenses.gpl2Plus;
+    platforms = [
+      "x86_64-linux"
+    ];
+    maintainers = with maintainers; [ wizardlink ];
+  };


Suggested change

meta = with lib; {

description = "DAW similar to FL Studio (music production software)";

mainProgram = "lmms";

homepage = "https://lmms.io";

license = licenses.gpl2Plus;

platforms = [

"x86_64-linux"

];

maintainers = with maintainers; [ wizardlink ];

};

meta = {

description = "DAW similar to FL Studio (music production software)";

mainProgram = "lmms";

homepage = "https://lmms.io";

license = lib.licenses.gpl2Plus;

platforms = [

"x86_64-linux"

];

maintainers = with lib.maintainers; [ wizardlink ];

};

auroraanna · 2025-10-01T12:07:36Z

pkgs/by-name/lm/lmms/package.nix

+    ++ lib.optionals withOptionals [
+      SDL2
+      alsa-lib
+      carla
+      fltk
+      fluidsynth
+      glibc_multi
+      lame
+      libgig
+      libjack2
+      libogg
+      libpulseaudio
+      libsoundio
+      libvorbis
+      lilv
+      lv2
+      perl540
+      perl540Packages.ListMoreUtils
+      perl540Packages.XMLParser
+      portaudio
+      sndio
+      suil
+      winePackage
+    ];


having the default package be without any audio doesn't make sense tbh.
i'd go for having a sensible default package and then allowing people to create the own version by calling the derivation with different arguments.

like if you really wanted to make the most use of this you could have separate flags for jack, alsa and pulseaudio and then a combined withAudio flag that is the true by default.

no audio by default on a DAW feels wrong... Should probably at least enable that.

auroraanna · 2025-10-01T12:14:58Z

Since tags weren't reset/removed, nor source did change, i'd suggest not replacing the version itself with 0, you can use 1.2.2-unstable-DATE.

And probably additionally specify that you moved it to /by-name

what do you mean, source didn't change? i think labeling it 1.2.2-xxx is bad, also since 1.2.2 is not the latest version tag, that is an alpha version.

mio-19 · 2025-10-11T08:45:38Z

pkgs/top-level/all-packages.nix


  linphone = libsForQt5.callPackage ../applications/networking/instant-messengers/linphone { };

-  lmms = libsForQt5.callPackage ../applications/audio/lmms {


Where is the new lmms added?

under pkgs/by-name/lm/lmms is the derivation. it automatically gets a package named lmms that way.

dotlambda

Please update to a commit including LMMS/lmms@c91c81e so we can fix #450908.

dotlambda · 2025-10-11T20:26:53Z

pkgs/by-name/lm/lmms/package.nix

+in
+stdenv.mkDerivation {
+  pname = "lmms";
+  version = "0-unstable-2025-01-28";


Suggested change

version = "0-unstable-2025-01-28";

version = "1.2.2-unstable-2025-01-28";

it is called 1.3.0-alpha in program

That doesn't matter.

Unstable is versioned as date and last release tag. So yes, 1.2.2-unstable-... is the way

That doesn't matter.

presumably because the github release page says the release 1.3.0-alpha.1 may be changed at any time without notice? as in, it's not really a version at all…

dotlambda · 2025-10-11T20:26:58Z

pkgs/by-name/lm/lmms/package.nix

+    owner = "LMMS";
+    repo = "lmms";
+    rev = "2c674eca3accbc6dab6f5aacbf34f7bd85af767e";
+    sha256 = "sha256-jq3Wog5BHBWIq5iLEBrHWIvYSzmKsCdb63Nu7j9kJRY=";


Suggested change

sha256 = "sha256-jq3Wog5BHBWIq5iLEBrHWIvYSzmKsCdb63Nu7j9kJRY=";

hash = "sha256-jq3Wog5BHBWIq5iLEBrHWIvYSzmKsCdb63Nu7j9kJRY=";

mio-19 · 2025-10-12T06:48:19Z

On the current lmms latest commit if withOptionals=true we need to clone a wine git repo and patch https://github.com/LMMS/lmms/blob/807751dc4dce53583ecf4140b67a5dc343c789a7/plugins/VstBase/CMakeLists.txt#L55

After this change I am able to build lmms with withOptionals=true https://github.com/mio-19/nurpkgs/blob/c5a0d1d1ae08a63a99378c26c91a5af45ac0ba17/pkgs/lmms/0001-wine-path-patch.patch https://github.com/mio-19/nurpkgs/blob/c5a0d1d1ae08a63a99378c26c91a5af45ac0ba17/pkgs/lmms/package.nix#L40

mio-19 · 2025-10-12T11:23:05Z

I'm honestly not too sure about the withOptionals argument I require here, because lmms without the optional dependencies doesn't even has ALSA support, but at the same time, packing a wine derivation seems quite expensive for a package. So defining the limits of "optional" for a NixOS package seems tough here for me.

How about providing the necessary support by default and offering an lmms-minimal package without Wine or other dependencies?

LordGrimmauld · 2025-10-14T18:50:12Z

pkgs/by-name/lm/lmms/package.nix

+in
+stdenv.mkDerivation {
+  pname = "lmms";
+  version = "0-unstable-2025-01-28";


Unstable is versioned as date and last release tag. So yes, 1.2.2-unstable-... is the way

LordGrimmauld · 2025-10-14T18:52:30Z

pkgs/by-name/lm/lmms/package.nix

+    ];
+
+  patches = lib.optionals withOptionals [
+    (substitute {


isn't replaceVars preferred over substitute?

LordGrimmauld · 2025-10-14T19:00:32Z

pkgs/by-name/lm/lmms/package.nix

+    ++ lib.optionals withOptionals [
+      SDL2
+      alsa-lib
+      carla
+      fltk
+      fluidsynth
+      glibc_multi
+      lame
+      libgig
+      libjack2
+      libogg
+      libpulseaudio
+      libsoundio
+      libvorbis
+      lilv
+      lv2
+      perl540
+      perl540Packages.ListMoreUtils
+      perl540Packages.XMLParser
+      portaudio
+      sndio
+      suil
+      winePackage
+    ];


no audio by default on a DAW feels wrong... Should probably at least enable that.

BeatLink · 2025-10-16T20:12:07Z

Any updates on this?

wizardlink · 2025-10-17T23:25:50Z

Yes, I went through this MR's recent comments, so I'll be making adjustments on the coming days - had been quite busy. o/

MultisampledNight · 2025-10-27T03:45:27Z

Thanks for the work you're doing either way! ^^

denisfalqueto · 2025-11-01T19:07:05Z

Since tags weren't reset/removed, nor source did change, i'd suggest not replacing the version itself with 0, you can use 1.2.2-unstable-DATE.
And probably additionally specify that you moved it to /by-name

what do you mean, source didn't change? i think labeling it 1.2.2-xxx is bad, also since 1.2.2 is not the latest version tag, that is an alpha version.

I agree with that! If a codebase is tagged with a version, that implies that a new version is being opened for contribution. So a better version forward would be 1-unstable or smh.

denisfalqueto · 2025-11-01T19:14:45Z

LMMS build is broken in nixpkgs-unstable.

CMake Error at CMakeLists.txt:1 (CMAKE_MINIMUM_REQUIRED):
  Compatibility with CMake < 3.5 has been removed from CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.

There is a bug report upstream: LMMS/lmms#7822 and a reference to a PR on upstream's upstream... lukas-w/qt5-x11embed#7

I believe we should patch the nix derivation to apply a cmake minimum version, until lmms solves that bug themselves.

LordGrimmauld · 2025-11-01T19:23:16Z

So a better version forward would be 1-unstable or smh.

No. Our documentation says "latest upstream version preceding that commit", followed by unstable and date, see https://github.com/NixOS/nixpkgs/tree/master/pkgs#versioning. This is how package trackers such as https://repology.org consume our data. Breaking with this pattern is wrong and bad. 1.2.2 -> 0-... would be considered a downgrade by our versioning logic, which this is not. I will block anything that does not fulfill those requirements.

I believe we should patch the nix derivation to apply a cmake minimum version

This is being done in this PR? I am confused what you are implying, other than "yes, do these changes"

There is a bug report upstream: LMMS/lmms#7822 and a reference to a PR on upstream's upstream... lukas-w/qt5-x11embed#7

Thank you for the extra context!

denisfalqueto · 2025-11-01T19:35:10Z

No. Our documentation says "latest upstream version preceding that commit", followed by unstable and date, see https://github.com/NixOS/nixpkgs/tree/master/pkgs#versioning. This is how package trackers such as https://repology.org consume our data. Breaking with this pattern is wrong and bad. 1.2.2 -> 0-... would be considered a downgrade by our versioning logic, which this is not. I will block anything that does not fulfill those requirements.

Thanks for the information, I didn't know there was a ruling about that.

I believe we should patch the nix derivation to apply a cmake minimum version

This is being done in this PR? I am confused what you are implying, other than "yes, do these changes"

Yes, the fix is being pulled through LMMS master branch. They already updated their version of qt5-x11embedded, so it seems everything will be alright. I'll have to wait for this current PR to be merged. Lmms on nixpkgs-unstable is broken right now...

Thank you for the extra context!

You're welcome and I thank you for all your contributions for Nix!

mio-19 · 2025-11-01T23:29:49Z

LMMS build is broken in nixpkgs-unstable.
CMake Error at CMakeLists.txt:1 (CMAKE_MINIMUM_REQUIRED):
  Compatibility with CMake < 3.5 has been removed from CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.
There is a bug report upstream: LMMS/lmms#7822 and a reference to a PR on upstream's upstream... lukas-w/qt5-x11embed#7

I believe we should patch the nix derivation to apply a cmake minimum version, until lmms solves that bug themselves.

I have tried this approach, however it still doesn't build. See #449868

I tried this pr's changes. With lmms updated to recent git commits, it builds. https://github.com/mio-19/nurpkgs/tree/main/pkgs/lmms

kira-bruneau · 2025-11-09T22:36:14Z

It looks like compatibility with CMake 4 was fixed in #459874.

github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 29, 2025

wizardlink force-pushed the lmms branch from 66e2559 to a6fb471 Compare January 30, 2025 03:47

lmms: 1.2.2 -> 0-unstable-2025-01-28

1e6acfb

LMMS 1.2.2 is almost 5 years old and the software has undergone many changes since then, unfortunately however, no branches or tags are being made as the software progresses so we stay as close to git as possible.

wizardlink force-pushed the lmms branch from a6fb471 to 1e6acfb Compare February 5, 2025 16:29

acid-bong suggested changes Mar 5, 2025

View reviewed changes

wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 7, 2025

nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 3, 2025

nixpkgs-ci bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 30, 2025

auroraanna suggested changes Oct 1, 2025

View reviewed changes

mio-19 mentioned this pull request Oct 11, 2025

lmms: fix build against CMake >= 3.5 #449868

Closed

13 tasks

mio-19 reviewed Oct 11, 2025

View reviewed changes

dotlambda requested changes Oct 11, 2025

View reviewed changes

dotlambda linked an issue Oct 11, 2025 that may be closed by this pull request

Build failure: lmms - cmake 4.0 #450908

Closed

3 tasks

Sigmanificient mentioned this pull request Oct 12, 2025

Tracking: Build Failures with CMake 4 #445447

Open

17 tasks

LordGrimmauld requested changes Oct 14, 2025

View reviewed changes

Necoro mentioned this pull request Nov 7, 2025

Build failure: lmms #459469

Closed

3 tasks

kira-bruneau added 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign and removed 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign labels Nov 8, 2025

jaredmontoya mentioned this pull request Mar 18, 2026

lmms: 1.2.2 -> 1.2.2-unstable-2026-04-01 #501041

Open

13 tasks


		linphone = libsForQt5.callPackage ../applications/networking/instant-messengers/linphone { };

		lmms = libsForQt5.callPackage ../applications/audio/lmms {

	version = "0-unstable-2025-01-28";
	version = "1.2.2-unstable-2025-01-28";

	sha256 = "sha256-jq3Wog5BHBWIq5iLEBrHWIvYSzmKsCdb63Nu7j9kJRY=";
	hash = "sha256-jq3Wog5BHBWIq5iLEBrHWIvYSzmKsCdb63Nu7j9kJRY=";

Uh oh!

Conversation

wizardlink commented Jan 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Things done

Uh oh!

wizardlink commented Jan 30, 2025

Uh oh!

wizardlink commented Feb 5, 2025

Uh oh!

acid-bong left a comment

Choose a reason for hiding this comment

Uh oh!

wizardlink commented Mar 6, 2025

Uh oh!

auroraanna commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

auroraanna left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

auroraanna commented Oct 1, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

auroraanna Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dotlambda left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mio-19 commented Oct 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mio-19 commented Oct 12, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BeatLink commented Oct 16, 2025

Uh oh!

wizardlink commented Oct 17, 2025

Uh oh!

MultisampledNight commented Oct 27, 2025

Uh oh!

denisfalqueto commented Nov 1, 2025

Uh oh!

denisfalqueto commented Nov 1, 2025

Uh oh!

LordGrimmauld commented Nov 1, 2025

Uh oh!

denisfalqueto commented Nov 1, 2025

Uh oh!

mio-19 commented Nov 1, 2025

Uh oh!

kira-bruneau commented Nov 9, 2025

wizardlink commented Jan 28, 2025 •

edited

Loading

auroraanna commented Sep 30, 2025 •

edited

Loading

auroraanna Oct 11, 2025 •

edited

Loading

mio-19 commented Oct 12, 2025 •

edited

Loading