Skip to content

lmms: fix build against CMake >= 3.5#449868

Closed
mio-19 wants to merge 1 commit intoNixOS:masterfrom
mio-19:patch-5
Closed

lmms: fix build against CMake >= 3.5#449868
mio-19 wants to merge 1 commit intoNixOS:masterfrom
mio-19:patch-5

Conversation

@mio-19
Copy link
Copy Markdown
Contributor

@mio-19 mio-19 commented Oct 8, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@mio-19
Copy link
Copy Markdown
Contributor Author

mio-19 commented Oct 8, 2025

#445447

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 8, 2025
SuperSandro2000
SuperSandro2000 reviewed Oct 8, 2025
View reviewed changes
@SuperSandroBot
Copy link
Copy Markdown

SuperSandroBot commented Oct 8, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 449868
Commit: dd74a83d027460be9edb968c9fa56da971c31d6d (subsequent changes)
Merge: b23a589220ced36de4061461e7fd136870d3dcda

Logs: https://github.com/SuperSandro2000/nixpkgs-review-gha/actions/runs/18346127756

x86_64-linux

❌ 1 package failed to build:
  • lmms
Error logs: `x86_64-linux`
lmms 
* Stk Mallets                 : not found, please install libstk0-dev (or similar) ;if you require the Mallets instrument
* VST-instrument hoster       : not found, please install (lib)wine-dev (or similar) - 64 bit systems additionally need gcc-multilib and g++-multilib
* VST-effect hoster           : not found, please install (lib)wine-dev (or similar) - 64 bit systems additionally need gcc-multilib and g++-multilib
* CALF LADSPA plugins         : OK
* CAPS LADSPA plugins         : OK
* CMT LADSPA plugins          : OK
* TAP LADSPA plugins          : OK
* SWH LADSPA plugins          : OK
* GIG player                  : OK



IMPORTANT:

after installing missing packages, remove CMakeCache.txt before

running cmake again!


-- Configuring incomplete, errors occurred!

aarch64-linux

✅ No rebuilds

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@mio-19
Copy link
Copy Markdown
Contributor Author

mio-19 commented Oct 11, 2025

A simple fix isn't enough

       > * Stk Mallets                 : not found, please install libstk0-dev (or similar) ;if you require the Mallets instrument
       > * VST-instrument hoster       : not found, please install (lib)wine-dev (or similar) - 64 bit systems additionally need gcc-multilib and g++-multilib
       > * VST-effect hoster           : not found, please install (lib)wine-dev (or similar) - 64 bit systems additionally need gcc-multilib and g++-multilib

@mio-19
Copy link
Copy Markdown
Contributor Author

mio-19 commented Oct 11, 2025

#377643 would be better for this package

@mio-19 mio-19 closed this Oct 11, 2025
@mio-19 mio-19 mentioned this pull request Oct 11, 2025
Closed
3 tasks
@mio-19 mio-19 mentioned this pull request Nov 1, 2025
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mio-19 @SuperSandroBot @SuperSandro2000