Skip to content

rubyPackage: seperate pname and version#479452

Merged
jopejoe1 merged 1 commit intoNixOS:stagingfrom
jopejoe1:rubypackages-pname
Jan 15, 2026
Merged

rubyPackage: seperate pname and version#479452
jopejoe1 merged 1 commit intoNixOS:stagingfrom
jopejoe1:rubypackages-pname

Conversation

@jopejoe1
Copy link
Copy Markdown
Member

@jopejoe1 jopejoe1 commented Jan 12, 2026 •
edited
Loading

Works towards #103997

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. labels Jan 12, 2026
@jopejoe1 jopejoe1 changed the base branch from master to staging January 13, 2026 18:22
@nixpkgs-ci nixpkgs-ci Bot closed this Jan 13, 2026
@nixpkgs-ci nixpkgs-ci Bot reopened this Jan 13, 2026
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jan 13, 2026
@Cryolitia
Copy link
Copy Markdown
Member

Cryolitia commented Jan 14, 2026

Could you briefly explain the motivation behind this PR?

@jopejoe1
Copy link
Copy Markdown
Member Author

jopejoe1 commented Jan 14, 2026

Make ot possible to query version and pname of ruby packages like it is already possible for most of nixpkgs also see #103997 for some more info on that.

@Cryolitia
Copy link
Copy Markdown
Member

Cryolitia commented Jan 14, 2026

Make ot possible to query version and pname of ruby packages like it is already possible for most of nixpkgs also see #103997 for some more info on that.

please describe it in your commit message

Cryolitia
Cryolitia approved these changes Jan 15, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Cryolitia Cryolitia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM， thx

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jan 15, 2026
@jopejoe1 jopejoe1 mentioned this pull request Jan 15, 2026
Merged
13 tasks
wolfgangwalther
wolfgangwalther reviewed Jan 15, 2026
View reviewed changes
Comment thread pkgs/development/ruby-modules/gem/default.nix Outdated
@jopejoe1 @wolfgangwalther
rubyPackage: seperate pname and version
bac6a44 
Makes it possible to query version and pname of ruby packages,
making it to the standard level of nixpkgs
@jopejoe1 jopejoe1 added this pull request to the merge queue Jan 15, 2026
Merged via the queue into NixOS:staging with commit 883322c Jan 15, 2026
26 checks passed
@jopejoe1 jopejoe1 deleted the rubypackages-pname branch January 15, 2026 11:11
@jopejoe1 jopejoe1 mentioned this pull request Jan 26, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfgangwalther wolfgangwalther wolfgangwalther left review comments

@anthonyroussel anthonyroussel Awaiting requested review from anthonyroussel

@aschleck aschleck Awaiting requested review from aschleck

@manveru manveru Awaiting requested review from manveru

@nixy nixy Awaiting requested review from nixy

@Rucadi Rucadi Awaiting requested review from Rucadi

@SCOTT-HAMILTON SCOTT-HAMILTON Awaiting requested review from SCOTT-HAMILTON

@tylerjl tylerjl Awaiting requested review from tylerjl

@zimbatm zimbatm Awaiting requested review from zimbatm

+2 more reviewers

@guylamar2006 guylamar2006 guylamar2006 approved these changes

@Cryolitia Cryolitia Cryolitia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jopejoe1 @Cryolitia @guylamar2006 @wolfgangwalther