treewide: remove superfluous disabled#479090
Merged
mweinelt merged 1 commit intoNixOS:masterfrom Jan 11, 2026
Merged
Conversation
321ec56 to
52109c9
Compare
Member
|
I also proposed to remove pythonOlder some time ago, but i was meet with fabaff not agreeing on the idea (for pythonOlder 3.5 😅) See: |
There is no need to disable Python packages for Python versions that are
no longer in Nixpkgs.
This change was generated using the following script:
pattern='^\s*disabled\s*=\s*pythonOlder\s*"3\.\([0-9]\|10\)"\s*;\s*$'
for f in $(find -name '*.nix'); do
grep -q "$pattern" "$f" || continue
sed -i "/$pattern/d" "$f"
if [ $(grep -c pythonOlder "$f") == 1 ]; then
sed -i '/^\s*pythonOlder,\s*$/d' "$f"
fi
nixfmt "$f"
done
52109c9 to
1a04744
Compare
mweinelt
approved these changes
Jan 11, 2026
Member
mweinelt
left a comment
There was a problem hiding this comment.
Skimmed the result and it looks correct.
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no need to disable Python packages for Python versions that are no longer in Nixpkgs.
This change was generated using the following script:
Any suggestions for how to deal with two consecutive blank lines caused by the script?EDIT: running
nixfmtis enoughThings done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.