Skip to content

treewide: remove superfluous disabled#479090

Merged
mweinelt merged 1 commit intoNixOS:masterfrom
dotlambda:pythonOlder
Jan 11, 2026
Merged

treewide: remove superfluous disabled#479090
mweinelt merged 1 commit intoNixOS:masterfrom
dotlambda:pythonOlder

Conversation

@dotlambda
Copy link
Copy Markdown
Member

@dotlambda dotlambda commented Jan 11, 2026

There is no need to disable Python packages for Python versions that are no longer in Nixpkgs.
This change was generated using the following script:

pattern='^\s*disabled\s*=\s*pythonOlder\s*"3.\([0-9]\|10\)"\s*;\s*$'
for f in $(find -name '*.nix'); do
    grep -q "$pattern" "$f" || continue
    sed -i "/$pattern/d" "$f"
    if [ $(grep -c pythonOlder "$f") == 1 ]; then
        sed -i '/^\s*pythonOlder,\s*$/d' "$f"
    fi
    nixfmt "$f"
done

Any suggestions for how to deal with two consecutive blank lines caused by the script?
EDIT: running nixfmt is enough

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@Sigmanificient
Copy link
Copy Markdown
Member

Sigmanificient commented Jan 11, 2026

I also proposed to remove pythonOlder some time ago, but i was meet with fabaff not agreeing on the idea (for pythonOlder 3.5 😅)

See:

@dotlambda dotlambda linked an issue Jan 11, 2026 that may be closed by this pull request
There is no need to disable Python packages for Python versions that are
no longer in Nixpkgs.
This change was generated using the following script:

    pattern='^\s*disabled\s*=\s*pythonOlder\s*"3\.\([0-9]\|10\)"\s*;\s*$'
    for f in $(find -name '*.nix'); do
        grep -q "$pattern" "$f" || continue
        sed -i "/$pattern/d" "$f"
        if [ $(grep -c pythonOlder "$f") == 1 ]; then
            sed -i '/^\s*pythonOlder,\s*$/d' "$f"
        fi
        nixfmt "$f"
    done
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab 6.topic: tree-sitter Tree-sitter is a parser generator tool and an incremental parsing library. labels Jan 11, 2026
@dotlambda dotlambda marked this pull request as ready for review January 11, 2026 17:41
Copy link
Copy Markdown
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed the result and it looks correct.

@mweinelt mweinelt added this pull request to the merge queue Jan 11, 2026
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 11, 2026
Merged via the queue into NixOS:master with commit e5cb718 Jan 11, 2026
32 checks passed
@dotlambda dotlambda deleted the pythonOlder branch January 11, 2026 18:26
@dotlambda dotlambda mentioned this pull request Feb 9, 2026
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: tree-sitter Tree-sitter is a parser generator tool and an incremental parsing library. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tracking issue: The great pythonOlder purge

3 participants