The great python3.8 purge [1] (python == 3.5) #312552
The great python3.8 purge [1] (python == 3.5) #312552Sigmanificient wants to merge 1 commit intoNixOS:masterfrom
Conversation
There was a problem hiding this comment.
I don't agree with removing pythonOlder only because it mention "3.5". It should stay as it in many cases it was added manually and helps to track in some ways the state of the module in Nixpkgs. Same as going for modules which still use sha256, mention format = "setuptools"; or have six in their inputs.
While checking a couple of modules it showed that the entry is simply outdated. During mass updates pythonOlder is not checked. Also, upstream is not always aware what releases their module actually support and it doesn't have to align us. If upstream says python_requires=">=3.5" then our pythonOlder entry does reflect hat.
pkgs/development/python-modules/django-timezone-field/default.nix
Outdated
Show resolved
Hide resolved
1d9862d to
1c430ea
Compare
fabaff
left a comment
There was a problem hiding this comment.
I guess that there are more outdated entries.
|
The disabled attribute is for nixpkgs consumption only. It does not make sense to keep it around for Python versions we don't ship anymore. I'm absolutely for structural cleanup like that. |
Description of changes
part of: #312288
This pr removes all the mention of
pythonOlder 3.5.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.