Skip to content

soapysdrplay: 0.4.0 -> 0.5.2#472544

Closed
suhr wants to merge 1 commit intoNixOS:masterfrom
suhr:soapysdrplay
Closed

soapysdrplay: 0.4.0 -> 0.5.2#472544
suhr wants to merge 1 commit intoNixOS:masterfrom
suhr:soapysdrplay

Conversation

@suhr
Copy link
Copy Markdown
Contributor

@suhr suhr commented Dec 19, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot requested a review from pmenke-de December 19, 2025 23:22
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 19, 2025
pmenke-de added a commit to pmenke-de/nixpkgs that referenced this pull request Dec 20, 2025
@pmenke-de
soapysdr-sdrplay3: fix cmake minimum version
1f00095 
taken from NixOS#472544
pmenke-de
pmenke-de approved these changes Dec 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@pmenke-de pmenke-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

There is #446040 already though, which also updates to 0.5.2 whilst adding support for darwin (macOS).

I've now applied your fix regarding the minimum CMake version to that PR as well, so it should work (again), whichever PR gets merged (first)

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Dec 20, 2025
@pmenke-de pmenke-de mentioned this pull request Dec 20, 2025
Merged
13 tasks
@suhr
Copy link
Copy Markdown
Contributor Author

suhr commented Dec 20, 2025

Closed in favor of #446040.

@suhr suhr closed this Dec 20, 2025
github-merge-queue bot pushed a commit that referenced this pull request Apr 5, 2026
@pmenke-de
soapysdr-sdrplay3: fix cmake minimum version
e2db566 
taken from #472544
mkg20001 pushed a commit to mkg20001/nixpkgs that referenced this pull request Apr 5, 2026
@pmenke-de @mkg20001
soapysdr-sdrplay3: fix cmake minimum version
fe7a478 
taken from NixOS#472544
mkg20001 pushed a commit to mkg20001/nixpkgs that referenced this pull request Apr 6, 2026
@pmenke-de @mkg20001
soapysdr-sdrplay3: fix cmake minimum version
edc808e 
taken from NixOS#472544
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pmenke-de pmenke-de pmenke-de approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@suhr @pmenke-de