Conversation
|
Last time we tried this, there were reasons against doign that that I have to look up. |
|
wasn't planning to merge without approval from a maintainer! will mark as draft, feel free to mark as ready tor review once you have feedback |
|
Can you rebase against master, please? |
68cbbce to
a808a96
Compare
|
Did you pull latest master? Because the only merge-conflicting patch I'm aware of is still not on this branch (update to 1.1.54). |
a808a96 to
96c4660
Compare
|
Thought I had, but git fetch must not have gotten itself worked out. Solved. |
Removes usage of mkYarnPackage, the package.json file, and updates the updateScript to account for this. Also just some simple modernization to go along with it.
96c4660 to
53df699
Compare
Ma27
left a comment
There was a problem hiding this comment.
I'm not sure I understand where this is coming from, but $out/bin/meshcentral does
#! /usr/bin/env node
require("../meshcentral.js");
which means the service is a no-op now because the included file does
if (require.main === module) {
mainStart(); // Called directly, launch normally.
} else {
module.exports.mainStart = mainStart; // Required as a module, useful for winservice.js
}
i.e. we get the main module, but it's never invoked and thus the service exits immediately.
Do you have an idea where this is coming from?
Also, the nodejs version is inconsistent. I kinda wonder if we should just go to v22 as I don't find any documented constraints anyways 🤷
Closes NixOS#472246 While there's a refactoring of the package ongoing (NixOS#460508), the fix is trivial enough.
Closes NixOS#472246 While there's a refactoring of the package ongoing (NixOS#460508), the fix is trivial enough.
Closes NixOS#472246 While there's a refactoring of the package ongoing (NixOS#460508), the fix is trivial enough.
Closes NixOS#472246 While there's a refactoring of the package ongoing (NixOS#460508), the fix is trivial enough. (cherry picked from commit 232fe85)
|
Here's my updated fix: |
Removes usage of mkYarnPackage, the package.json file, and updates the updateScript to account for this.
Also just some simple modernization to go along with it.
Part of #324246
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.