docbook2x: allow configure to find osx#416216
Merged
ttuegel merged 1 commit intoNixOS:stagingfrom Jun 18, 2025
Merged
Conversation
Fixes NixOS#412735. NixOS#358347 / NixOS#400315 left the package broken because configure searces for osx in PATH and hardcodes its path on the Perl code. strictDeps logically prevents the dependency from being in PATH, so an empty string is hardcoded and `sgml2xml-isoent` doesn't work. The best fix that comes to mind is overriding the autoconf test result via the environment variable.
ttuegel
approved these changes
Jun 18, 2025
Member
ttuegel
left a comment
There was a problem hiding this comment.
I tested this out locally and it looks good to me!
13 tasks
This was referenced Jun 30, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #412735.
#358347 / #400315 left the package broken because configure searches for osx in PATH and hardcodes its path on the Perl code. strictDeps logically prevents the dependency from being in PATH, so an empty string is hardcoded and
sgml2xml-isoentdoesn't work.The best fix that comes to mind is overriding the autoconf test result via the environment variable.
I believe this is a more proper fix than #412736 (which would break cross).
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.