elmPackages.elm-coverage: drop#415911
Merged
wolfgangwalther merged 5 commits intoNixOS:haskell-updatesfrom Jun 13, 2025
Merged
Conversation
13 tasks
11 tasks
elm-verify-examples doesn't depend on elmi-to-json anymore.
I did not commit changes to node-composition.nix, which didn't seem intended.
70a7765 to
8eb258b
Compare
Contributor
Author
|
So, to regenerate the node packages to remove elm-coverage, I had to update them first before. But since a few packages were broken, I couldn't really verify the updates... thus I fixed this brokenness first. |
Contributor
Author
|
Contributor
Author
|
Looks good now, the only question remaining is: Are we OK with dropping |
Member
|
Seems fine to me. |
Member
|
I think there is no way elm-coverage could be kept going forward. So if it's not really question of if we can drop it but when we can drop it. |
Member
|
Why are you removing elm-instrument in the same PR and without further comment in the commit messages?
|
Member
|
The only reason elm-instrument was packaged was as a dependecy of elm-coverage. It's not useful for anything else not even as a stand alone thing. |
Contributor
Author
|
Yeah, I basically removed everything that was not used anymore after removing elm-coverage. But you're right, I could have written a bit more about that in the commit message. |
This allows dropping elmi-to-json, which in turn allows dropping GHC 8.10.7. Along with elmi-to-json, we can remove the patchBinwrap utility, which was only used for that purpose. Along with elm-coverage, we can also drop elm-instrument, which was only used as a dependency of the former, and it's reverse dependency indents.
8eb258b to
9404d8d
Compare
Contributor
Author
|
Adjusted the commit message accordingly, no other changes. |
turboMaCk
approved these changes
Jun 12, 2025
PedroHLC
approved these changes
Jun 12, 2025
35c090c
into
NixOS:haskell-updates
18 of 20 checks passed
13 tasks
Contributor
|
Interesting. It was just removed without any stub "here was elm-coverage but no longer". vs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #413234, one option is to drop
elm-coverage.I first tried to drop only
elmi-to-json, but didn't succeed (#413234 (comment)).Part of tracking issue: #346214
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usageAdd a 👍 reaction to pull requests you find important.