elmPackages.elm-instrument: build using GHC 9.4#413234
elmPackages.elm-instrument: build using GHC 9.4#413234turboMaCk merged 1 commit intoNixOS:haskell-updatesfrom
Conversation
As Emily has pointed out, elm-instrument builds with GHC 9.4 without any modifications. Later versions of GHC won't work due to the pinned indents package version which is affected by a breaking change in some core package.
054c7e0 to
d3af908
Compare
|
nixpkgs review fails for me with: I'm not sure if this is regression caused by this or not (yet). |
|
Confirmed that this is not regression caused by changes in this PR. elm-verify-examples is failing in master too. |
emilazy
left a comment
There was a problem hiding this comment.
LGTM.
I believe I was able to bump one or two others of these as well when testing, although I forget if I needed to do any patching. Not sure I still have the diff lying around.
|
I think there is only elmi-to-json left there. Which might be a bit harder but it shouldn't be rocket science either. |
|
Ah, I see |
|
elmi-to-json is dependecy of other package and that's it sole purpose (similar to elm-instrument). So it needs to be decided based on if we want to keep these other packages or not. |
|
The relevant packages seem to be
I can't find any other references to |
|
That seems correct. Elm-coverage is something that @domenkozar requested and I packaged myself if I'm correct. I don't see it as an important package so I think we can consider dropping it if keeping it will be proven difficult. |
|
While |
Since I didn't succeed with keeping it, here's my attempt to drop it: #415911. |
As Emily has pointed out, elm-instrument builds with GHC 9.4 without any modifications. Later versions of GHC won't work due to the pinned indents package version which is affected by a breaking change in some core package.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.