Skip to content

elmPackages.elm-instrument: build using GHC 9.4#413234

Merged
turboMaCk merged 1 commit intoNixOS:haskell-updatesfrom
sternenseemann:elm-instrument-9.4
Jun 11, 2025
Merged

elmPackages.elm-instrument: build using GHC 9.4#413234
turboMaCk merged 1 commit intoNixOS:haskell-updatesfrom
sternenseemann:elm-instrument-9.4

Conversation

@sternenseemann
Copy link
Copy Markdown
Member

As Emily has pointed out, elm-instrument builds with GHC 9.4 without any modifications. Later versions of GHC won't work due to the pinned indents package version which is affected by a breaking change in some core package.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@sternenseemann sternenseemann requested a review from maralorn June 2, 2025 13:46
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 2, 2025
As Emily has pointed out, elm-instrument builds with GHC 9.4 without any
modifications. Later versions of GHC won't work due to the pinned
indents package version which is affected by a breaking change in some
core package.
@turboMaCk
Copy link
Copy Markdown
Member

nixpkgs review fails for me with:

       > sed: can't read node_modules/elmi-to-json/package.json: No such file or directory
       For full logs, run:
         nix log /nix/store/gk2n0fpqy8410siw4njh8iqjhlayxj3i-elm-verify-examples-6.0.3.drv
error: 1 dependencies of derivation '/nix/store/lkf8d6rbl8zd9d2i3p6f9m47b1q18mbb-review-shell.drv' failed to build

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/413234
--------- Report for 'x86_64-linux' ---------
1 package failed to build:
elmPackages.elm-verify-examples

I'm not sure if this is regression caused by this or not (yet).

@turboMaCk
Copy link
Copy Markdown
Member

Confirmed that this is not regression caused by changes in this PR. elm-verify-examples is failing in master too.

Copy link
Copy Markdown
Member

@turboMaCk turboMaCk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I believe I was able to bump one or two others of these as well when testing, although I forget if I needed to do any patching. Not sure I still have the diff lying around.

@turboMaCk
Copy link
Copy Markdown
Member

I think there is only elmi-to-json left there. Which might be a bit harder but it shouldn't be rocket science either.

@turboMaCk turboMaCk merged commit 028a94b into NixOS:haskell-updates Jun 11, 2025
21 of 30 checks passed
@emilazy
Copy link
Copy Markdown
Member

emilazy commented Jun 11, 2025

Ah, I see elm-format was already moved. I also see that stoeffel/elmi-to-json#48 hasn’t moved at all, so maybe it’d be worth considering dropping elmi-to-json if possible…?

@turboMaCk
Copy link
Copy Markdown
Member

turboMaCk commented Jun 11, 2025

elmi-to-json is dependecy of other package and that's it sole purpose (similar to elm-instrument). So it needs to be decided based on if we want to keep these other packages or not.

@wolfgangwalther
Copy link
Copy Markdown
Contributor

The relevant packages seem to be elm-verify-examples (for elmi-to-json) and elm-coverage (for elmi-to-json and elm-instrument).

elm-verify-examples seems to have moved off of elmi-to-json a while ago: stoeffel/elm-verify-examples#99

elm-coverage doesn't seem to be maintained, but seems to be on the same versions of elm and elm-test that elm-verify-examples is on after that PR: https://github.com/zwilias/elm-coverage/blob/main/package.json

I can't find any other references to elmi-to-json in nixpkgs - so maybe we can just remove the references to it from those two preRebuild hooks without any further packages needed to drop?

@turboMaCk
Copy link
Copy Markdown
Member

That seems correct. Elm-coverage is something that @domenkozar requested and I packaged myself if I'm correct. I don't see it as an important package so I think we can consider dropping it if keeping it will be proven difficult.

@sternenseemann sternenseemann deleted the elm-instrument-9.4 branch June 11, 2025 15:14
@wolfgangwalther
Copy link
Copy Markdown
Contributor

While elm-coverage specifies recent enough elm and elm-test, somehow the generate-node-packages.sh script doesn't resolve to those versions for it, but instead to much older versions. I have no idea why that happens. But this causes elmi-to-json to stick around, even after updating the node packages.

@wolfgangwalther
Copy link
Copy Markdown
Contributor

I don't see it as an important package so I think we can consider dropping it if keeping it will be proven difficult.

Since I didn't succeed with keeping it, here's my attempt to drop it: #415911.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants