nixos: correct meta.maintainers#413092
Merged
drupol merged 2 commits intoNixOS:masterfrom Jun 2, 2025
Merged
Conversation
Became maintainer of nixos/jupyter in NixOS#367106. This error was not caught since meta.maintainer in nixos modules are not at the time of writing evaluated
`lib.maintainers.blackheaven` does not exist, but the github id matches `lib.maintainers.gdifolco` which corresponds with the author of NixOS#345656
13 tasks
blackheaven
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maintainers: add b-m-f
Became maintainer of nixos/jupyter in nixos/jupyter: migrate service to jupyter 7 setup #367106, but they did not add themselves to
maintainer-list.nix.This error was not caught since meta.maintainer in nixos modules are not at the time of writing evaluated
nixos/vivid: correct meta.maintainer
lib.maintainers.blackheavendoes not exist, but the github id matcheslib.maintainers.gdifolcowhich corresponds with the author of nixos/vivid: init module #345656cc @b-m-f and @blackheaven
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.