nixos/vivid: init module#345656
Merged
FliegendeWurst merged 1 commit intoNixOS:masterfrom Dec 29, 2024
Merged
Conversation
b9f36f2 to
3501e6f
Compare
FliegendeWurst
approved these changes
Oct 27, 2024
Contributor
Author
|
Can you have a look @zowoq please? |
Member
There was a problem hiding this comment.
Should go in 25.05 unless you want to have it backported.
Contributor
Author
There was a problem hiding this comment.
Nice catch! Thanks, fixed.
3501e6f to
e7d968b
Compare
nixos/modules/programs/vivid.nix
Outdated
Member
There was a problem hiding this comment.
I would suggest a strength of default + 1, otherwise the assertion below doesn't really work (right?)
Contributor
Author
There was a problem hiding this comment.
I would suggest a strength of default + 1,
I've used mkOverride 999, which is mkDefault - 1 (so, a higher priority), is it correct or is there a more idiomatic way to do it?
otherwise the assertion below doesn't really work (right?)
Let me come up with a simple case.
Member
There was a problem hiding this comment.
is it correct or is there a more idiomatic way to do it?
It seems like the best option to me. You essentially want to replace the default value with another default. There are 3 other uses of the pattern I can find.
Contributor
Author
There was a problem hiding this comment.
Assertions are working:
-- sandbox.nix
{ config, pkgs, ... }:
{
boot.loader.systemd-boot.enable = true;
boot.loader.efi.canTouchEfiVariables = true;
programs = {
vivid.enable = true;
bash.enableLsColors = true;
zsh.enableLsColors = false;
};
system.stateVersion = "25.05";
}
gives:
$ nix-build './nixos' -A vm -I nixos-config=./sandbox.nix
error:
… while calling the 'derivationStrict' builtin
at <nix/derivation-internal.nix>:34:12:
33|
34| strict = derivationStrict drvAttrs;
| ^
35|
… while evaluating derivation 'nixos-vm'
whose name attribute is located at /home/black/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:375:7
… while evaluating attribute 'buildCommand' of derivation 'nixos-vm'
at /home/black/nixpkgs/pkgs/build-support/trivial-builders/default.nix:59:17:
58| enableParallelBuilding = true;
59| inherit buildCommand name;
| ^
60| passAsFile = [ "buildCommand" ]
… while evaluating the option `virtualisation.vmVariant.system.build.toplevel':
… while evaluating definitions from `/home/black/nixpkgs/nixos/modules/system/activation/top-level.nix':
(stack trace truncated; use '--show-trace' to show the full, detailed trace)
error:
Failed assertions:
- `programs.vivid.enable` is incompatible with `programs.bash.enableLsColors`.
e7d968b to
dc24d11
Compare
dc24d11 to
4e57e46
Compare
FliegendeWurst
approved these changes
Dec 29, 2024
pbsds
added a commit
to pbsds/nixpkgs
that referenced
this pull request
Jun 2, 2025
`lib.maintainers.blackheaven` does not exist, but the github id matches `lib.maintainers.gdifolco` which corresponds with the author of NixOS#345656
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted a way to configure
vivid(aLS_COLORSmanager) simply, but it requires disable default flags from other moducle, so it seems more foolproof to have a dedicated module for this.Things done
Created a module
programs.vivid.nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.