timidity: fix symlink permissions for Darwin build#380440
Merged
doronbehar merged 2 commits intoNixOS:masterfrom Feb 9, 2025
Merged
timidity: fix symlink permissions for Darwin build#380440doronbehar merged 2 commits intoNixOS:masterfrom
doronbehar merged 2 commits intoNixOS:masterfrom
Conversation
All but one of the symlinks in the instruments.tar.gz tarball have their permissions set to 0000. This causes noBrokenSymlinks to fail silently at readlink on systems like Darwin/macOS that actually care about symlink permissions. It also seems to be the reason that turning on `dontRewriteSymlinks` on Darwin was necessary. Resolves NixOS#380436.
3 tasks
Rhys-T
commented
Feb 8, 2025
Contributor
Author
|
One other thing I forgot to mention: The source URL for that instruments tarball (http://www.csee.umbc.edu/pub/midia/instruments.tar.gz) is now redirecting to https://news.cs.umbc.edu/pub/midia/instruments.tar.gz, which gets a 404. (It's not causing errors yet because cache.nixos.org still has it.) The actual current URL seems to be https://courses.cs.umbc.edu/pub/midia/instruments.tar.gz. Should I add that into this PR, or open a separate PR for it? |
3 tasks
Contributor
Do it here please. |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
I'll also run a nixpkgs-review on aarch64-darwin for this PR afterwards, just to make sure we don't observe #380501 again. |
Contributor
Author
Thanks, just pushed it. |
Contributor
|
Contributor
|
No new failures according to |
Rhys-T
added a commit
to Rhys-T/nur-packages
that referenced
this pull request
Feb 11, 2025
Shouldn't be necessary anymore for the most part, since those changes have made it into nixpkgs-unstable. But this fixes it for users who haven't updated their channel yet. Also remove `meta.broken` flags related to NixOS/nixpkgs#380436, since they aren't needed anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All but one of the symlinks in the instruments.tar.gz tarball have their permissions set to 0000. This causes noBrokenSymlinks to fail silently at readlink on systems like Darwin/macOS that actually care about symlink permissions. It also seems to be the reason that turning on
dontRewriteSymlinkson Darwin was necessary.Resolves #380436.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.