cosmic-ext-tweaks: init at 0.1.3#379419
Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom Feb 13, 2025
Merged
Conversation
33 tasks
Contributor
|
340c903 to
410607e
Compare
GaetanLepage
reviewed
Feb 5, 2025
Contributor
GaetanLepage
left a comment
There was a problem hiding this comment.
Same remarks as in #379412:
- Why not naming this package just
cosmic-tweaks? - Hardcode the path to the binary and don't use
meta.mainProgram
410607e to
38fa1a5
Compare
Contributor
|
GaetanLepage
approved these changes
Feb 5, 2025
Member
|
ethancedwards8
approved these changes
Feb 7, 2025
38fa1a5 to
b5801b9
Compare
Member
Author
|
Updated to use the new |
Member
Author
|
b5801b9 to
e86d97f
Compare
GaetanLepage
approved these changes
Feb 13, 2025
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.