cosmic-ext-calculator: init at 0.1.1#379412
Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom Feb 13, 2025
Merged
Conversation
33 tasks
Tert0
reviewed
Feb 4, 2025
01755f2 to
d28f615
Compare
GaetanLepage
reviewed
Feb 4, 2025
Contributor
|
d28f615 to
3198b46
Compare
GaetanLepage
reviewed
Feb 5, 2025
13 tasks
3198b46 to
1ee2ee1
Compare
GaetanLepage
approved these changes
Feb 5, 2025
Contributor
GaetanLepage
left a comment
There was a problem hiding this comment.
LGTM !
@lilyinstarlight maybe you want to have a quick look at this before merging :)
Contributor
|
1ee2ee1 to
46b8283
Compare
Member
Author
|
Also updated to use the new |
46b8283 to
863c3a0
Compare
863c3a0 to
3451497
Compare
GaetanLepage
approved these changes
Feb 13, 2025
Contributor
|
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.