cosmic-calculator: init at 0-unstable-2024-09-07#340725
Closed
callumio wants to merge 1 commit intoNixOS:masterfrom
Closed
cosmic-calculator: init at 0-unstable-2024-09-07#340725callumio wants to merge 1 commit intoNixOS:masterfrom
callumio wants to merge 1 commit intoNixOS:masterfrom
Conversation
Member
Author
|
Result of 1 package built:
|
33 tasks
Pandapip1
suggested changes
Oct 23, 2024
Comment on lines
+75
to
+80
| --prefix LD_LIBRARY_PATH : "${ | ||
| lib.makeLibraryPath [ | ||
| libxkbcommon | ||
| wayland | ||
| ] | ||
| }" |
Member
There was a problem hiding this comment.
Can't the LD_LIBRARY_PATH prefix wrap be replaced by autoPatchelfHook?
HeitorAugustoLN
requested changes
Dec 24, 2024
Comment on lines
+27
to
+43
| cargoLock = { | ||
| lockFile = ./Cargo.lock; | ||
| outputHashes = { | ||
| "accesskit-0.12.2" = "sha256-1UwgRyUe0PQrZrpS7574oNLi13fg5HpgILtZGW6JNtQ="; | ||
| "atomicwrites-0.4.2" = "sha256-QZSuGPrJXh+svMeFWqAXoqZQxLq/WfIiamqvjJNVhxA="; | ||
| "clipboard_macos-0.1.0" = "sha256-cG5vnkiyDlQnbEfV2sPbmBYKv1hd3pjJrymfZb8ziKk="; | ||
| "cosmic-config-0.1.0" = "sha256-AmgRihxFMq6pQotz/Qqbzo04dVGkxx1pSiQwfBG3kjY="; | ||
| "cosmic-settings-daemon-0.1.0" = "sha256-QAFlbT66P7MDFJf+BFrCwUqNinEAcXpimqVa59OaAh8="; | ||
| "cosmic-text-0.12.1" = "sha256-sZjYGyGRu9sg81SdCw44I0/re/BtSyz/tSZPgM6cl70="; | ||
| "d3d12-0.19.0" = "sha256-usrxQXWLGJDjmIdw1LBXtBvX+CchZDvE8fHC0LjvhD4="; | ||
| "glyphon-0.5.0" = "sha256-j1HrbEpUBqazWqNfJhpyjWuxYAxkvbXzRKeSouUoPWg="; | ||
| "smithay-clipboard-0.8.0" = "sha256-4InFXm0ahrqFrtNLeqIuE3yeOpxKZJZx+Bc0yQDtv34="; | ||
| "softbuffer-0.4.1" = "sha256-a0bUFz6O8CWRweNt/OxTvflnPYwO5nm6vsyc/WcXyNg="; | ||
| "taffy-0.3.11" = "sha256-SCx9GEIJjWdoNVyq+RZAGn0N71qraKZxf9ZWhvyzLaI="; | ||
| "winit-0.29.10" = "sha256-ScTII2AzK3SC8MVeASZ9jhVWsEaGrSQ2BnApTxgfxK4="; | ||
| }; | ||
| }; |
Member
There was a problem hiding this comment.
It would be better to set useFetchCargoVendor = true instead of vendoring the Cargo.lock.
Comment on lines
+51
to
+54
| buildInputs = [ | ||
| wayland | ||
| libxkbcommon | ||
| ]; |
Member
There was a problem hiding this comment.
vulkan-loader and libGL are generally needed by libcosmic applications too
Suggested change
| buildInputs = [ | |
| wayland | |
| libxkbcommon | |
| ]; | |
| buildInputs = [ | |
| wayland | |
| libxkbcommon | |
| vulkan-loader | |
| libGL | |
| ]; |
Comment on lines
+56
to
+57
| dontUseJustBuild = true; | ||
|
|
Member
There was a problem hiding this comment.
Also disable just check.
Suggested change
| dontUseJustBuild = true; | |
| dontUseJustBuild = true; | |
| dontUseJustCheck = true; |
| commitDate = "2024-09-07"; | ||
| in | ||
| rustPlatform.buildRustPackage rec { | ||
| pname = "cosmic-calculator"; |
Member
There was a problem hiding this comment.
The package name is cosmic-ext-calculator in upstream, so I think this should be renamed to it
13 tasks
Member
|
Superseeded by #379412 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds a calculator application for the COSMIC Desktop.
Fixes #337554
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.