Merged
Conversation
Mindavi
added a commit
to Mindavi/nixpkgs
that referenced
this pull request
Dec 2, 2024
…ptions I chose to not constrain them to the supported values to be more flexible in supporting any newly added values. But maybe it makes sense to constrain them, I'm not completely sure. Ran into this because Prometheus 3.0 was introduced last week and my config broke, since rtl_433 doesn't set the headers / content-type correctly. Related-to: NixOS#358862 Related-to: prometheus/prometheus#15136
13 tasks
hsjobeki
pushed a commit
to hsjobeki/nixpkgs
that referenced
this pull request
Dec 3, 2024
…ptions I chose to not constrain them to the supported values to be more flexible in supporting any newly added values. But maybe it makes sense to constrain them, I'm not completely sure. Ran into this because Prometheus 3.0 was introduced last week and my config broke, since rtl_433 doesn't set the headers / content-type correctly. Related-to: NixOS#358862 Related-to: prometheus/prometheus#15136
Member
|
@fpletz Is there a reason this upgrade hasn't been documented in the release notes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/prometheus/prometheus/releases/tag/v3.0.0
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.