Merged
Conversation
steeleduncan
suggested changes
Nov 17, 2024
Contributor
|
Could this be rebased to two commits, the first adding you as a maintainer, the second adding the package? |
FliegendeWurst
requested changes
Nov 25, 2024
FliegendeWurst
approved these changes
Nov 29, 2024
| fetchFromGitHub, | ||
| }: | ||
|
|
||
| buildPythonPackage rec { |
Member
There was a problem hiding this comment.
It looks like the module is only used as application. In that case it should go in pkgs/by-name and use buildPythonApplication
Contributor
Author
There was a problem hiding this comment.
Excellent suggestion. This is so much nicer now and I also figured out how to run the tests during the build. Thank you.
Could you take another look at reviewing?
Member
There was a problem hiding this comment.
Had another look :)
I can review functionality most likely tomorrow.
0a4aa73 to
77faa06
Compare
FliegendeWurst
approved these changes
Feb 8, 2025
jjtt
added a commit
to jjtt/cfv
that referenced
this pull request
Feb 8, 2025
Add a section for NixOS. See NixOS/nixpkgs#356778
jjtt
added a commit
to jjtt/cfv
that referenced
this pull request
Feb 9, 2025
Add a section for NixOS. See NixOS/nixpkgs#356778
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cfv – Command-line File Verify
cfv is a utility to test and create a wide range of checksum verification files. It currently supports testing and creating sfv, sfvmd5, csv, csv2, csv4, md5, bsdmd5, sha1, sha224, sha256, sha384, sha512, torrent and crc files. Test-only support is available for par, par2.
cfv was originally written by Matthew Mueller. Version in GitHub (https://github.com/cfv-project/cfv) is a friendly fork of cfv maintained by David Lisa Gnedt.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.