nodejs_23: add patches to fix parallel-os test#356257
Merged
emilazy merged 1 commit intoNixOS:masterfrom Nov 20, 2024
Merged
Conversation
51d9fde to
8ef8cb8
Compare
Member
Author
|
@ofborg build nodePackages_latest.nodejs Already built it locally, but asking ofborg anyway to ensure it works on other platforms as well |
aduh95
reviewed
Nov 15, 2024
13 tasks
8ef8cb8 to
71e4f92
Compare
Member
Author
|
PR updated to use the patch from nodejs/node#55908 instead. @ofborg build nodePackages_latest.nodejs |
FIXME: remove after a point release containing the patches
71e4f92 to
28bcb44
Compare
Member
Author
|
@ofborg build nodePackages_latest.nodejs |
aduh95
approved these changes
Nov 20, 2024
emilazy
approved these changes
Nov 20, 2024
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.05
git worktree add -d .worktree/backport-356257-to-release-24.05 origin/release-24.05
cd .worktree/backport-356257-to-release-24.05
git switch --create backport-356257-to-release-24.05
git cherry-pick -x 28bcb4477dfeddda89e0c61e6d1e78379a66d29f |
Contributor
|
Successfully created backport PR for |
1 task
FliegendeWurst
added a commit
to FliegendeWurst/nixpkgs
that referenced
this pull request
Nov 27, 2024
2 tasks
2 tasks
emilazy
pushed a commit
to emilazy/nixpkgs
that referenced
this pull request
Jan 5, 2025
Same as NixOS#356257 (cherry picked from commit cb05815)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert after a point release containing the patches.
Closes #355919
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.