Skip to content

treewide: replace passthru.optional-dependencies with optional-dependencies#345232

Merged
mweinelt merged 1 commit intoNixOS:masterfrom
dotlambda:optional-dependencies
Sep 30, 2024
Merged

treewide: replace passthru.optional-dependencies with optional-dependencies#345232
mweinelt merged 1 commit intoNixOS:masterfrom
dotlambda:optional-dependencies

Conversation

@dotlambda
Copy link
Copy Markdown
Member

@dotlambda dotlambda commented Sep 29, 2024

Description of changes

I just ran sed -i s/passthru\\.optional-dependencies/optional-dependencies/g **/*.nix and manually fixed eval errors.
This leaves a lot of things like

passthru = {
  optional-dependencies = {
    ...
  };
};

untouched.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab labels Sep 29, 2024
@mweinelt mweinelt marked this pull request as draft September 29, 2024 11:21
@dotlambda dotlambda force-pushed the optional-dependencies branch 3 times, most recently from 3e6254a to d1cbb99 Compare September 29, 2024 22:20
@dotlambda dotlambda force-pushed the optional-dependencies branch from d1cbb99 to 5437810 Compare September 30, 2024 03:37
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 30, 2024
@dotlambda dotlambda marked this pull request as ready for review September 30, 2024 04:39
@mweinelt mweinelt merged commit 27b4e63 into NixOS:master Sep 30, 2024
@dotlambda dotlambda deleted the optional-dependencies branch September 30, 2024 14:40
imincik added a commit to imincik/geospatial-nix that referenced this pull request Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants