Merged
Conversation
Member
|
Maybe it's better to store patch file in nixpkgs in case upstream gets rebased/diaappears after merging but other than that, LGTM |
Member
Author
I think this is fine, as fetchpatch is used nearly 3000 times in nixpkgs, including elsewhere in this file. But I'm happy to change it if others think it needs changing. |
Member
|
Result of 3 packages built:
|
Member
|
Storing the patch in nixpkgs would only add additional work to the already huge pile. If we can fetch a patch then we should as this make tracking easier. Sure, it could disappear but the same applies for almost all sources. |
13 tasks
dc-tec
added a commit
to dc-tec/nixos-config
that referenced
this pull request
Aug 18, 2024
…kes (#40) - Configured waybar on second monitor. - Use the stable package of AWSCLI2 due to build issue on unsable see: NixOS/nixpkgs#334858. The merge hasn't yet propogated. For now use stable package. - Update flake inputs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Apply the patch from an upstream PR until it's merged, to fix an awscli2 test failure, caused by a dependency update.
Nixpkgs issue: #334730
Upstream PR: aws/aws-cli#8838
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.