Skip to content

libvmi: 0.12.0 -> 0.14.0-unstable-2024-08-06, libkvmi: init at 1.1.0-unstable-2023-12-13#328873

Merged
SuperSandro2000 merged 4 commits intoNixOS:masterfrom
SigmaSquadron:libvmi-unstable
Sep 11, 2024
Merged

libvmi: 0.12.0 -> 0.14.0-unstable-2024-08-06, libkvmi: init at 1.1.0-unstable-2023-12-13#328873
SuperSandro2000 merged 4 commits intoNixOS:masterfrom
SigmaSquadron:libvmi-unstable

Conversation

@SigmaSquadron
Copy link
Copy Markdown
Contributor

@SigmaSquadron SigmaSquadron commented Jul 21, 2024 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review pr 328873".
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) No release notes: change is not major.
  • Fits CONTRIBUTING.md.

Resolves this upstream request.

Add a 👍 reaction to pull requests you find important.

@SigmaSquadron SigmaSquadron mentioned this pull request Jul 21, 2024
Merged
6 tasks
@SigmaSquadron
Copy link
Copy Markdown
Contributor Author

SigmaSquadron commented Jul 21, 2024

@matthiasbeyer: Hi! I understand if you no longer wish to have anything to do with libvmi, but if you are interested, I would appreciate any comments you may have on this update. Use it with the first three commits from #324693.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 21, 2024
@SigmaSquadron SigmaSquadron mentioned this pull request Jul 21, 2024
Closed
@SigmaSquadron
Copy link
Copy Markdown
Contributor Author

SigmaSquadron commented Jul 21, 2024

Dropping patch: Build failure was fixed upstream.

@matthiasbeyer
Copy link
Copy Markdown
Contributor

matthiasbeyer commented Jul 22, 2024

Hi! Thanks for working on this!

Two options:

The simple one would be, you add a patch (as first patch of the PR) removing me as maintainer (feel free to add my Signed-off-by) and add yourself. After that, do what you want 😆

The not-so-simple one, if you don't want to take maintainership is: Split your libvmi: 0.12.0 -> 0.14.0... patch into three patches: One that moves the package to pkgs/by-name, one that formats it and one that updates it.
It is really hard to review the patchset this way, that's why I'd like to see this patch splitted.

Hope that helps! 😉

SigmaSquadron added a commit to SigmaSquadron/nixpkgs that referenced this pull request Jul 31, 2024
@SigmaSquadron
libvmi: mark broken
8d4151a 
In file included from ./driver/xen/xen_private.h:42,
  error: unknown type name 'xc_dominfo_t'; did you mean 'xc_meminfo_t'?

PR NixOS#328873 reverts this commit and updates LibVMI.

Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
@SigmaSquadron SigmaSquadron force-pushed the libvmi-unstable branch 2 times, most recently from 8fa4bc9 to 926647e Compare August 1, 2024 19:14
@SigmaSquadron SigmaSquadron marked this pull request as ready for review August 1, 2024 19:23
@SigmaSquadron
Copy link
Copy Markdown
Contributor Author

SigmaSquadron commented Aug 1, 2024

The not-so-simple one, if you don't want to take maintainership is: Split your libvmi: 0.12.0 -> 0.14.0... patch into three patches: One that moves the package to pkgs/by-name, one that formats it and one that updates it. It is really hard to review the patchset this way, that's why I'd like to see this patch splitted.

@matthiasbeyer: Thanks for hanging in there! The main Xen PR was merged, so I can finish up with this PR.
As requested, the libvmi update commit has been split in three separate patches. I do plan on maintaining this package, and you haven't been a maintainer since e9304d7, I just requested one final review from you as the sole LibVMI maintainer before the package was orphaned.

  • Passes nixpkgs-hammering libvmi -e attribute-typo. (libVersion is not a typo.)

  • Result of nixpkgs-review pr 328873 run on x86_64-linux 1

    6 packages built:
    • libkvmi
    • libkvmi.dev
    • libkvmi.lib
    • libvmi
    • libvmi.dev
    • libvmi.lib

@SigmaSquadron SigmaSquadron changed the title WIP: libvmi: 0.12.0 -> 0.14.0-unstable-2024-02-05, libkvmi: init at 1.1.0-unstable-2023-12-13 WIP: libvmi: 0.12.0 -> 0.14.0-unstable-2024-07-25, libkvmi: init at 1.1.0-unstable-2023-12-13 Aug 1, 2024
@SigmaSquadron SigmaSquadron changed the title WIP: libvmi: 0.12.0 -> 0.14.0-unstable-2024-07-25, libkvmi: init at 1.1.0-unstable-2023-12-13 libvmi: 0.12.0 -> 0.14.0-unstable-2024-07-25, libkvmi: init at 1.1.0-unstable-2023-12-13 Aug 1, 2024
@SigmaSquadron
Copy link
Copy Markdown
Contributor Author

SigmaSquadron commented Aug 3, 2024 •
edited
Loading

Looks like Lib(k)VMI doesn't support AArch64 at all. Dropping the platform.

@ofborg ofborg bot added the 8.has: clean-up This PR removes packages or removes other cruft label Aug 3, 2024
SuperSandro2000
SuperSandro2000 reviewed Aug 22, 2024
View reviewed changes
@SigmaSquadron
libkvmi: init at 1.1.0-unstable-2023-12-13
f28182d 
Required dependency for recent versions of libvmi.

Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
@SigmaSquadron
libvmi: move to pkgs/by-name
39fd9bb 
Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
@SigmaSquadron
libvmi: format with nixfmt-rfc-style
0fae3ce 
Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
@SigmaSquadron SigmaSquadron changed the title libvmi: 0.12.0 -> 0.14.0-unstable-2024-07-25, libkvmi: init at 1.1.0-unstable-2023-12-13 libvmi: 0.12.0 -> 0.14.0-unstable-2024-08-06, libkvmi: init at 1.1.0-unstable-2023-12-13 Aug 22, 2024
@SigmaSquadron
Copy link
Copy Markdown
Contributor Author

SigmaSquadron commented Aug 22, 2024

Result of nixpkgs-review pr 328873 run on x86_64-linux 1

6 packages built:
  • libkvmi
  • libkvmi.dev
  • libkvmi.lib
  • libvmi
  • libvmi.dev
  • libvmi.lib

drupol
drupol reviewed Sep 9, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@drupol drupol left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make a very small opinionated change request. I think this is a good place where using lib.optionals makes more sense than using lib.optional.

@SigmaSquadron
libvmi: 0.12.0 -> 0.14.0-unstable-2024-08-06
6c437af 
Also splits the package output and adds more configuration options.

Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
@SuperSandro2000 SuperSandro2000 merged commit 981d54d into NixOS:master Sep 11, 2024
@SigmaSquadron SigmaSquadron deleted the libvmi-unstable branch September 11, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drupol drupol drupol left review comments

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees

No one assigned

Labels

8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SigmaSquadron @matthiasbeyer @drupol @SuperSandro2000