Skip to content

python3Packages: remove unused fetchpath and other arguments#313980

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
Sigmanificient:pypkgs-remove-unused-fetchpatch
May 23, 2024
Merged

python3Packages: remove unused fetchpath and other arguments#313980
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
Sigmanificient:pypkgs-remove-unused-fetchpatch

Conversation

@Sigmanificient
Copy link
Copy Markdown
Member

@Sigmanificient Sigmanificient commented May 23, 2024

Description of changes

This is a follow-up pr from the previous cleanup pr, since it did well:

I continued remove unused fetchpatch arguments, targeting the ones within pkgs/development/python-modules.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 23, 2024
@Sigmanificient Sigmanificient changed the title pythonPackages: remove unused fetchpath arguments pythonPackages: remove unused fetchpath and other arguments May 23, 2024
@natsukium natsukium changed the title pythonPackages: remove unused fetchpath and other arguments python3Packages: remove unused fetchpath and other arguments May 23, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 23, 2024
@SuperSandro2000 SuperSandro2000 merged commit d0ce4f8 into NixOS:master May 23, 2024
@Sigmanificient Sigmanificient deleted the pypkgs-remove-unused-fetchpatch branch May 23, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants