Skip to content

vim-language-server: init at 2.3.1#296847

Merged
doronbehar merged 1 commit intoNixOS:masterfrom
doronbehar:pkg/vim-language-server
Mar 23, 2024
Merged

vim-language-server: init at 2.3.1#296847
doronbehar merged 1 commit intoNixOS:masterfrom
doronbehar:pkg/vim-language-server

Conversation

@doronbehar
Copy link
Copy Markdown
Contributor

@doronbehar doronbehar commented Mar 18, 2024

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@doronbehar doronbehar force-pushed the pkg/vim-language-server branch from 33cceae to df08296 Compare March 18, 2024 08:58
@doronbehar doronbehar mentioned this pull request Mar 18, 2024
Closed
@doronbehar doronbehar force-pushed the pkg/vim-language-server branch from df08296 to 4a57532 Compare March 18, 2024 09:51
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Mar 18, 2024
@nixos-discourse
Copy link
Copy Markdown

nixos-discourse commented Mar 21, 2024

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3665

AndersonTorres
AndersonTorres reviewed Mar 22, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides, LGTM

@doronbehar doronbehar force-pushed the pkg/vim-language-server branch from 4a57532 to 578ee3b Compare March 23, 2024 18:01
@doronbehar doronbehar merged commit 744a812 into NixOS:master Mar 23, 2024
@doronbehar doronbehar deleted the pkg/vim-language-server branch March 23, 2024 18:37
tomodachi94 added a commit to tomodachi94/nixpkgs that referenced this pull request Jun 25, 2024
@tomodachi94
nodePackages.vim-language-server: drop
427e92a 
Replaced by the mainspace "vim-language-server", which was added in.
NixOS#296847.

Added an alias to the above.
@tomodachi94 tomodachi94 mentioned this pull request Jun 25, 2024
Merged
13 tasks
@tomodachi94 tomodachi94 mentioned this pull request Oct 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@AndersonTorres AndersonTorres AndersonTorres left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@doronbehar @nixos-discourse @AndersonTorres