Skip to content

nixos/cosmic-greeter: init; nixos/cosmic: init#292601

Closed
nyabinary wants to merge 2 commits intoNixOS:masterfrom
nyabinary:cosmic-module
Closed

nixos/cosmic-greeter: init; nixos/cosmic: init#292601
nyabinary wants to merge 2 commits intoNixOS:masterfrom
nyabinary:cosmic-module

Conversation

@nyabinary
Copy link
Copy Markdown
Contributor

@nyabinary nyabinary commented Mar 1, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 1, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 1, 2024
@RAVENz46
Copy link
Copy Markdown
Member

RAVENz46 commented Mar 6, 2024

I am still inexperienced with nix, so I am sorry I can't help you with anything but requests, is it possible to make some packages excludable (e.g. cosmic-edit, files, ... ) like the gnome module?

@lilyinstarlight
Copy link
Copy Markdown
Member

I am still inexperienced with nix, so I am sorry I can't help you with anything but requests, is it possible to make some packages excludable (e.g. cosmic-edit, files, ... ) like the gnome module?

This is implemented now in https://github.com/lilyinstarlight/nixos-cosmic (which is the repo we are using for testing these modules and packages)

@RAVENz46
Copy link
Copy Markdown
Member

RAVENz46 commented Mar 6, 2024

@lilyinstarlight
I didn't know that repo.
Thanks.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label May 3, 2024
@h7x4 h7x4 added the 8.has: module (new) This PR adds a module in `nixos/` label Jun 1, 2024
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 3, 2024
@nyabinary
Copy link
Copy Markdown
Contributor Author

nyabinary commented Dec 30, 2024

Superseded by #369113

@nyabinary nyabinary closed this Dec 30, 2024
@Lord-Valen
Copy link
Copy Markdown
Contributor

I think you meant #369113

@nyabinary
Copy link
Copy Markdown
Contributor Author

I think you meant #369113

Yep my bad :P

@nyabinary nyabinary deleted the cosmic-module branch February 7, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants