Conversation
fdfc65e to
8718969
Compare
|
Please make sure to explain the motivation in the commit message. At first glance this looks very complicated… |
It simplifies building and packaging all apps made with libcosmic, also there is the fact that there was no hook for building libcosmic apps before, so every maintainer freestyled it. This provides a level of standarization. |
winterqt
left a comment
There was a problem hiding this comment.
Do you feel comfortable enough maintaining this for Nixpkgs on your own, or are you going to keep plucking changes from Lily's repo?
I feel like lifting this from a perfectly working flake without actually adding it to any existing packages (does it even work with them?) is maybe not the best of ideas.
|
Those are reasonable concerns.
|
Lord-Valen
left a comment
There was a problem hiding this comment.
As is, this needs attribution to @lilyinstarlight by inclusion of the nixos-cosmic license.
|
Superseded by #369113 |
Description of changes
Adds libcosmicAppHook for libcosmic apps.
Upstreamed from nixos-cosmic by @lilyinstarlight
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.