Conversation
|
Well, we're only at -2 here. IIRC the textual patches really were quite large sometimes, but I don't recall investigating deeply whether to compress or not. |
This was not about the current state of course given that the release is only 11 days old. The glibc with most patches on top was 2.35-224 according to https://www.nixhub.io/packages/glibc.
This is an increase of 1.2% in a very bad case (224 additional patches).
Yes. When we're sufficiently confident in x86_64-linux, we can probably do another eval (perhaps even aarch64-linux only) to see if there are big regressions (only built the stdenv there so far).
Considering how far I got I assumed the rev to be sufficiently OK. But it's perhaps better for Hydra comparisons, so I guess I'll find a merge-base of staging{,-next}. |
|
There's nothing in |
|
|
I'm afraid, I'm not sure what you mean here?
It's not urgent at all, I can wait :) |
|
I mean that all of the current |
|
Hydra will now have time due to catching up on darwin work: |
|
The libpng thing is unrelated. I'll deal with that and restart failures after it succeeds. EDIT: done now. |
|
What's the status on this? I'm quite interested in being able to start getting more CET stuff in place (e.g. #288052) |
|
Well, anyone could triage the regressions, as it's on public Hydra (and in cache.nixos.org even!) |
|
It's on my list high up (I even have a lot of tabs open for potential regressions I need to check) and I'll try to get to it this week! :) |
|
Going through the list of failures, I'm finding the vast majority to just be flakey builds that have subsequently succeeded for me. |
|
So, the only regression I found is https://hydra.nixos.org/build/249763145 (_389ds-base). See also 389ds/389-ds-base#5962. However, the package is pretty outdated (not even the latest patch-level for the minor we have) and the patch doesn't apply, so I'll just mark it as broken and leave it to the maintainer. Haven't seen anything else. I only built aarch64-linux's stdenv so far, nothing more. So perhaps we want to do one Hydra eval of aarch64-linux as well? |
|
cc @ners re _389ds-base. |
|
Indeed, see #285042. 2.4.5 seems to fix it for me, and the suggested patch un-breaks 32bit. |
|
Failures retried, so that it's easier to focus on real regressions. |
|
|
|
So, out of direct comparison with https://hydra.nixos.org/eval/1804335?compare=1804178&full=0#tabs-now-fail:
The following things are reproducible regressions on x86_64-linux and don't seem like flaky builds:
Seems as if the |
|
Regarding swift (https://hydra.nixos.org/build/249763077/nixlog/12): the issue here is apparently glibc commit 64b1a44183a3094672ed304532bedb9acc707554 (marks |
Announcement: https://lists.gnu.org/archive/html/info-gnu/2024-01/msg00017.html This release seems relatively harmless in terms of potential fallout. Most notably is the removal of `crypt(3)` in favor of libxcrypt which we've done already and compatibility from ISO C2X. Also decided to drop the old *.gz approach in favor of inlining the patch with the changes from the release branch directly: it's relatively small in contrast to certain lockfiles in this repo and having a textual version makes reviews & diffs easier. See also NixOS#258972 (comment) for more context.
Doesn't build with glibc 2.39. There's a potential fix documented in 389ds/389-ds-base#5332, but the package is too old for the patch to apply, so I'll mark it as broken for now and leave it to the maintainer to update & fix.
Failing Hydra build: https://hydra.nixos.org/build/249763077/nixlog/12 The problem is that glibc commit 64b1a44183a3094672ed304532bedb9acc707554 marked the `FILE*` argument of a few functions including `fread` & `ferror` as non-null. The applied patch ("Android: add better nullability checks for nullability annotations added in NDK 26") is targeted for the Android platform, but fixes said issue as well: the handle returned from `fopen` is of type `Optional<T>` and the `guard` expression unwraps that now (and throws an exception if `nil` is returned). The previous `nil`-check didn't modify the type of `fp`, but only raised the exception and moved on with `Optional<T>`. It's a little sad that the patch needs to be applied at so many places, but I guess that's what you get with language-level package managers 🤷 Also, seems good-enough to me given that it's actually temporary, the patch is already upstream and will probably be obsolete at one of the next Swift updates.
|
Rebased onto the rev from https://hydra.nixos.org/eval/1804706, that should give us a good comparison. Starting an eval now. |
Failing Hydra build: https://hydra.nixos.org/build/252105318
Failing Hydra build: https://hydra.nixos.org/build/252068803
|
Two more fixes pushed. Seems as if the rest are flaky tests (or failures, but no fresh regressions): https://hydra.nixos.org/eval/1804710?full=1&compare=1804706#tabs-now-fail wdyt? |
|
Uh, lots of newly failing and newly succeeding in there. (even after retrying everything; though most "new failures" is |
|
Anyway, if you've passed through a diff and found no (significant) regressions, it should be good to merge, I believe. |
I don't see any new build failures and just to be sure I picked a few things that seemingly failed during e.g. the checkPhase and built locally. Some of them needed a few tries, but that's nothing that should block this branch. |
|
This PR broke the use of |
Description of changes
Announcement: https://lists.gnu.org/archive/html/info-gnu/2024-01/msg00017.html
This release seems relatively harmless in terms of potential fallout.
Most notably is the removal of
crypt(3)in favor of libxcrypt whichwe've done already and compatibility from ISO C2X.
Also decided to drop the old *.gz approach in favor of inlining the
patch with the changes from the release branch directly: it's relatively
small in contrast to certain lockfiles in this repo and having a textual
version makes reviews & diffs easier. See also
#258972 (comment) for
more context.
cc @vcunat would you mind creating a hydra jobset in the nixpkgs project for that?
I got relatively far already (built firefox on x86_64-linux and stdenv on aarch64 and aarch64 cross), but I'd still like to see a little more.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.