Merged
Conversation
kirillrdy
approved these changes
Feb 10, 2024
Contributor
|
Hi, first of all, I want to apologize for posting an off-topic message here. I need help with setting up 389ds on NixOS, but there doesn't seem to be many that have that experience on the discourse forum, so I thought I might try asking the packagers. Any help is gratefully appreciated 🙏 |
Member
Author
|
No worries, but let's continue the discussion over at discourse :) |
risicle
reviewed
Feb 26, 2024
Contributor
|
This PR is needed to fix build against glibc 2.39 #287594 |
Member
|
👍 This should really be merged (without the patch would still unblock x86_64 at least) but now also needs to revert 1c003da to unmark the package as broken. |
Co-authored-by: Robert Scott <github@humanleg.org.uk>
Member
|
Thanks for this PR - we're still a few versions behind, but at least the package can be built again now! |
13 tasks
Contributor
|
Successfully created backport PR for |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Comparison: 389ds/389-ds-base@389-ds-base-2.4.3...389-ds-base-2.4.5
Release notes:
maintainers: @ners
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.