Skip to content

check-by-name: Update pinned version#284765

Merged
infinisil merged 2 commits intoNixOS:masterfrom
tweag:by-name-update-pin
Jan 29, 2024
Merged

check-by-name: Update pinned version#284765
infinisil merged 2 commits intoNixOS:masterfrom
tweag:by-name-update-pin

Conversation

@infinisil
Copy link
Copy Markdown
Member

Description of changes

Makes the pkgs/by-name CI check use #283017 by updating the pinned tool using update-pinned-tool.sh.

Also includes #282226.

This work is sponsored by Antithesis and Tweag


Add a 👍 reaction to pull requests you find important.

Original commit from NixOS#282226,
message:

Running CI locally is broken becauses the `-I` argument:

- Clobbers $NIX_PATH
- Is wrong for two reasons:
  - Has too many `..` elements, relative to the script's location
  - Isn't relative to the script's location (as with *.nix files),
    since shell scripts and POSIX in general interpret paths
    relative to the current working directory, not the canonical
    path of argv[0]
- Is inconsistent, since this script has symlinks pointing at it
  from different depths in the repository

There is no way to set this flag statically in a way that will work
everywhere.  The caller needs to use $NIX_PATH, or the script needs
to take the `-I` value as an argument.

This commit deletes the static `-I` flag.
@infinisil infinisil added this to the RFC 140 milestone Jan 29, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 29, 2024
@infinisil infinisil merged commit 5139a60 into NixOS:master Jan 29, 2024
@infinisil infinisil deleted the by-name-update-pin branch January 29, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant