treewide: remove unreferenced patch files#271362
Merged
Mindavi merged 1 commit intoNixOS:masterfrom Dec 6, 2023
Merged
Conversation
kirillrdy
reviewed
Dec 1, 2023
...evelopment/tools/godot/3/mono/patches/gen_cs_glue_version.py/hardcodeGlueVersion_3.5.2.patch
Outdated
Show resolved
Hide resolved
Found with `fd \\.patch$ pkgs/ -x bash -c 'rg -F "{/}" pkgs/ -q || echo {}'`
684c6b7 to
f41aba3
Compare
katexochen
approved these changes
Dec 2, 2023
Contributor
There was a problem hiding this comment.
I went through the file history of all the patches that were modified less than a year ago. Nearly all were just forgotten to remove when their reference was deleted. The gcc patches were moved and refactored recently (911452c), I've verified they weren't referenced before. I'd say patches older than a year won't be missed if they're not referenced anywhere.
ghost
reviewed
Dec 3, 2023
ghost
left a comment
There was a problem hiding this comment.
gcc changes look good to me. did not review the rest.
Mindavi
approved these changes
Dec 6, 2023
Contributor
Mindavi
left a comment
There was a problem hiding this comment.
I checked some things and those seem fine. Ofborg is happy.
13 tasks
13 tasks
pbsds
added a commit
to pbsds/nixpkgs
that referenced
this pull request
Jul 25, 2024
repeat of NixOS#271362 Found with `fd \\.patch$ pkgs/ -x bash -c 'rg -F "{/}" pkgs/ -q || echo {}'`` Should cause 0 rebuilds.
13 tasks
13 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found with
fd \\.patch$ pkgs/ -x bash -c 'rg -F "{/}" pkgs/ -q || echo {}'The only false positives seem to be the
godot3-mono-gluepatch, which has a${version}in the file name, and theflutterpatches inpkgs/development/compilers/flutter/patches/, which are fetched withbuiltins.readDir.Should be good if ofborg claims 0 rebuilds
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Priorities
Add a 👍 reaction to pull requests you find important.