dxvk: change targetPlatform to hostPlatform#267291
Closed
Conversation
Contributor
|
It looks like this changes a lot more than |
Contributor
stdenv.targetPlatform really shouldn't be used by software that doesn't generate or manipulate binaries; I think the package was using the wrong platform.
Author
Fixed, thanks. |
Author
|
Closed in favor of |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
stdenv.targetPlatformreally shouldn't be used by software that doesn't generate or manipulate binaries.I did a mass replacement in #267229 and this was the only package for which the change affected eval on Linux, so I'm putting it in a
separate PR.
If the previous behavior was correct, we should document why
targetPlatformis used here.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)