jbig2dec: fix cross#266254
Merged
Conversation
jbig2dec's ./autogen.sh script expects to call ./configure itself, so any flags we want to have passed to ./configure (like --host) need to be passed to autogen.sh. The simple way to accomplish this is to simply set configureScript to autogen.sh.
Mindavi
approved these changes
Nov 9, 2023
Author
|
This can wait until after 23.11 branch-off. |
This was referenced Dec 17, 2023
Merged
brianmcgillion
added a commit
to brianmcgillion/ghaf
that referenced
this pull request
May 31, 2024
fixed in upstream NixOS/nixpkgs#266254 Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
brianmcgillion
added a commit
to tiiuae/ghaf
that referenced
this pull request
Jun 3, 2024
fixed in upstream NixOS/nixpkgs#266254 Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
jbig2dec's ./autogen.sh script expects to call ./configure itself, so any flags we want to have passed to ./configure (like --host) need to be passed to autogen.sh.
The simple way to accomplish this is to simply set configureScript to autogen.sh.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)