Skip to content

ocamlPackages.eio: 0.12 → 0.13#265029

Merged
vbgl merged 1 commit intoNixOS:masterfrom
toastal:ocaml-eio-0.13
Nov 3, 2023
Merged

ocamlPackages.eio: 0.12 → 0.13#265029
vbgl merged 1 commit intoNixOS:masterfrom
toastal:ocaml-eio-0.13

Conversation

@toastal
Copy link
Copy Markdown
Contributor

@toastal toastal commented Nov 2, 2023

https://github.com/ocaml-multicore/eio/releases/tag/v0.13

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@toastal toastal requested a review from ulrikstrid as a code owner November 2, 2023 14:21
@toastal toastal changed the title ocamlPackages: 0.12 → 0.13 ocamlPackages.eio: 0.12 → 0.13 Nov 2, 2023
@github-actions github-actions bot added the 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. label Nov 2, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 2, 2023
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer true. And that breaks wayland-proxy-virtwl: you may consider keeping version 0.12 around for compatibility with OCaml 5.0.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we try this??

@toastal toastal requested a review from vbgl November 3, 2023 16:53
@ofborg ofborg bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 3, 2023
@vbgl vbgl merged commit f60921a into NixOS:master Nov 3, 2023
@vbgl
Copy link
Copy Markdown
Contributor

vbgl commented Nov 3, 2023

Thanks!

natsukium pushed a commit to natsukium/nixpkgs that referenced this pull request Nov 4, 2023
@cafkafk cafkafk mentioned this pull request Nov 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants