nixos/virt-manager: init module (option 1)#261474
Merged
bjornfor merged 1 commit intoNixOS:masterfrom Oct 18, 2023
Merged
Conversation
Contributor
Author
|
If I wrote documentation for this, would it be under "new services" or "other notable changes"? |
Member
|
There is precedent for "new services" |
Contributor
Author
Contributor
|
Should at least have a |
Contributor
Author
Oh yeah right, I'll add that |
e961d12 to
e49f74f
Compare
pbsds
requested changes
Oct 16, 2023
Gerg-L
reviewed
Oct 16, 2023
e92509e to
ced22aa
Compare
ced22aa to
cfd396d
Compare
pbsds
approved these changes
Oct 16, 2023
the-furry-hubofeverything
added a commit
to the-furry-hubofeverything/hubble-systems
that referenced
this pull request
Oct 17, 2023
Upstream in progress on nixpkgs with NixOS/nixpkgs#261474
khaneliman
approved these changes
Oct 18, 2023
pbsds
approved these changes
Oct 18, 2023
bjornfor
approved these changes
Oct 18, 2023
Contributor
|
Thanks! |
K900
added a commit
to K900/nixpkgs
that referenced
this pull request
Nov 3, 2023
Was missed in NixOS#261474
13 tasks
natsukium
pushed a commit
to natsukium/nixpkgs
that referenced
this pull request
Nov 4, 2023
Was missed in NixOS#261474
EndCredits
added a commit
to EndCredits/nix-configurations
that referenced
this pull request
Jan 26, 2024
* Refs: NixOS/nixpkgs#261474 Signed-off-by: EndCredits <endcredits@crepuscular-aosp.icu>
Jayman2000
added a commit
to Jayman2000/jasons-nixos-config
that referenced
this pull request
Mar 8, 2024
When I first set up virt-manager [1], there was no programs.virt-manager modoption. Now that there is [2], I can simplify my code by using it. [1]: 60370fd (Set up desktop for hosting VMs, 2022-07-19) [2]: <NixOS/nixpkgs#261474> TODO: • Test on: ◦ Graphical-Test-VM ◦ Jason-Desktop-Linux • Back up any links in the Internet Archive.
Jayman2000
added a commit
to Jayman2000/jasons-nixos-config
that referenced
this pull request
Mar 8, 2024
When I first set up virt-manager [1], there was no programs.virt-manager modoption. Now that there is [2], I can simplify my code by using it. [1]: 60370fd (Set up desktop for hosting VMs, 2022-07-19) [2]: <NixOS/nixpkgs#261474> TODO: • Test on: ◦ Jason-Desktop-Linux • Back up any links in the Internet Archive.
Jayman2000
added a commit
to Jayman2000/jasons-nixos-config
that referenced
this pull request
Mar 8, 2024
When I first set up virt-manager [1], there was no programs.virt-manager modoption. Now that there is [2], I can simplify my code by using it. [1]: 60370fd (Set up desktop for hosting VMs, 2022-07-19) [2]: <NixOS/nixpkgs#261474> TODO: • Back up any links in the Internet Archive.
Jayman2000
added a commit
to Jayman2000/jasons-nixos-config
that referenced
this pull request
Mar 8, 2024
When I first set up virt-manager [1], there was no programs.virt-manager modoption. Now that there is [2], I can simplify my code by using it. [1]: 60370fd (Set up desktop for hosting VMs, 2022-07-19) [2]: <NixOS/nixpkgs#261474>
Jayman2000
added a commit
to Jayman2000/jasons-nixos-config
that referenced
this pull request
Dec 5, 2024
I first added virt-manager to my NixOS config in 60370fd (Set up desktop for hosting VMs, 2022-07-19). At the time, NixOS didn’t have an official virt-manager module. NixOS’s official virt-manager module wasn’t added until 2023 [1]. If the module had existed at the time, I would have used it. The main motivation behind this change is to fix a problem that I’m currently experiencing with virt-manager. I’m not able to view a virtual machie’s display. Whenever I try to view a virtual machine’s display, I get this error: > Error connecting to graphical console: > Error opening SPICE console: Typelib file for namespace 'GstBase', > version '1.0' not found Interestingly enough, that error message has already been reported as a Nixpkgs bug, and that bug has already been fixed [2]. If the bug has already been fixed, then why am I experiencing it? One possible explanation is that the bug is fixed for people who are using the virt-manager module but not fixed for people who are using the virt-manager package directly. If that’s the case, then this change will (hopefully) make that error message go away. Additionally, this change allows me to make my config slightly shorter. Even if this change doesn’t end up fixing the problem, making my NixOS config shorter is still a good thing. [1]: <NixOS/nixpkgs#261474 (comment)> [2]: <NixOS/nixpkgs#267579 (comment)>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes #67736, fixes #257171
Virt-manager is unable to store settings without dconf, so I wrote a simple nixos module for it.
I've never written something of the sort, feedback appreciated. It works on my setup, but I'm not used to testing modules on my machine.
This is one of the options what was suggested, where a module is written to enable dconf and virt-manager at the same time. If another option is perferred over this, please let me know, and discuss further in #257171.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)