Conversation
matthiasbeyer
left a comment
There was a problem hiding this comment.
Please change your commit message(s) to match the commit message conventions of nixpkgs!
|
PR for maintainership added in #252559, once merged I'll remove from this PR to prevent failures. |
7cab113 to
fd01e2f
Compare
|
Realised it made more sense to place it under |
|
I think I've narrowed it down to the |
|
Success! We have a building and running app. |
|
As a sidenote, this could theoretically support all the platforms, but I don't have the ability to test at the moment, so sticking the with default x86 Linux. |
26a3329 to
4d4c9eb
Compare
|
@matthiasbeyer Don't mean to bug you but I'd love another review on this :) |
|
Well I don't think I am qualified to review yarn packaging, sorry. |
Per https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#changes-acceptable-for-releases it's perfectly fine to backport new packages. We don't usually do it unless someone cares / requests it, but it's fine to do so. |
delroth
left a comment
There was a problem hiding this comment.
Disclaimer: I also don't know much about the yarn ecosystem in nixpkgs. But nothing in this PR seems particularly wrong to me, and in absence of a more qualified reviewer having a look I'd be happy to see this merged.
One tiny comment if you don't mind doing another change to this PR.
629e796 to
ee0b424
Compare
The commit message issue was addressed earlier already, assuming this is obsolete based on the latest PR comment.
|
(CI is now failing due to trailing whitespaces.) |
ee0b424 to
5942921
Compare
|
Fixed trailing spaces. |
|
Result of 1 package built:
|
|
Successfully created backport PR for |
Description of changes
Create the RedisInsight package (#242438).
While Redis provides AppImages and other packages, these are not well versioned, only containing the major version the binary was built for. Thus the only way to get proper versioning, from what I can tell, is to build from source.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)